Logic question

[toptaran]

Hello,
I'm trying to backport it for python 3.7 work to add to GOG launcher as plugin, found weird place that I do not really understand.
Can you explain it to me?

psnawp/src/psnawp_api/models/trophies/trophy_group.py

Lines 346 to 354 in dd0359c

	merged_trophy_groups: list[dict[str, Any]] = [
	x[0] | x[1]
	for x in zip(
	trophy_groups_metadata.get("trophyGroups"),
	trophy_groups_user_data.get("trophyGroups"),
	strict=False,
	)
	]
	merged_data["trophyGroups"] = merged_trophy_groups

Why do you use this weird construction?
Is not it same as?

merged_trophy_groups: list[dict[str, Any]] = trophy_groups_metadata.get("trophyGroups").copy()
merged_trophy_groups[0].update(trophy_groups_user_data.get("trophyGroups")[0])

I thought to backport for python 3.7 it as such, but I'm not sure is it correct.

merged_trophy_groups: list[dict[str, Any]] = trophy_groups_metadata.get("trophyGroups").copy()
merged_trophy_groups[0].update(trophy_groups_user_data.get("trophyGroups")[0])

[isFakeAccount]

@toptaran This is dict merge syntax, I believe it was added in python 3.9.

If you want to rewrite this as python 3.7 then you might wanna change this to

 merged_trophy_groups: list[dict[str, Any]] = [ 
     x[0].update(x[1]) 
     for x in zip( 
         trophy_groups_metadata.get("trophyGroups"), 
         trophy_groups_user_data.get("trophyGroups"), 
         strict=False, 
     ) 
 ] 

This also works. Maybe even more clear

merged_trophy_groups: list[dict[str, Any]] = []

for meta, user_data in zip(
   trophy_groups_metadata.get("trophyGroups"), 
   trophy_groups_user_data.get("trophyGroups"), 
   strict=False
):
   meta.update(user_data)
   merged_trophy_groups.append(meta)

[toptaran]

@isFakeAccount Yeah, I'm understand it.
Main question why do you use zip?
Both lists are always 1 element, you can replace this construction

 merged_trophy_groups: list[dict[str, Any]] = [ 
     x[0] | x[1] 
     for x in zip( 
         trophy_groups_metadata.get("trophyGroups"), 
         trophy_groups_user_data.get("trophyGroups"), 
         strict=False, 
     ) 
 ] 

with this

merged_trophy_groups: list[dict[str, Any]] = [
    trophy_groups_metadata.get("trophyGroups")[0] | trophy_groups_user_data.get("trophyGroups")[0]
]

Maybe I'm asking some obvious question, I'm not a python developer, so I spent some time to understand original construction and still do not understand necessity to use zip here.

[isFakeAccount]

@toptaran they are not always 1 element. Perhaps you are only looking at games with no expansions and DLC. There will be multiple trophy groups with games that have expansions.

[isFakeAccount]

Fallout76 (NPWR15509_00) for example has multiple expansions so it has multiple trophyGroups

[toptaran]

@isFakeAccount Oh, I got it now, thank you so much for your explanation, I really did miss this thing!