[2.10.0] Wrongly removes parentheses

[boris-petrov]

Prettier-Java 2.10.0

--print-width 80

Input:

return a != null && (b == c);
(minimumRelevanceScore * 2) - 1;

Output:

return a != null && b == c;
minimumRelevanceScore * 2 - 1;

Expected behavior:
Unchanged.

The second line is not technically incorrect but I personally don't like parentheses removed in such expressions. There is a long-standing issue in Prettier for JS for the same thing. The first one is wrong because it changes the meaning of the program.

P.S. I now see that Prettier for JS does the same thing. Horrible. And maybe it's because of the same issue. I would like Prettier for Java to be better than that! 😄

[ZachCallear]

P.S. I now see that Prettier for JS does the same thing. Horrible. And maybe it's because of the same issue. I would like Prettier for Java to be better than that! 😄

In my opinion, this plugin ought to model its behavior after Prettier for JS as closely as possible, within the realm of things where JavaScript and Java are not too radically different from each other.

[boris-petrov]

I absolutely agree. EXCEPT this case. 😄 Check the Prettier issue - it has hundreds and hundreds of "likes" and comments - obviously many people want the other behavior. So I'm for either an option or just doing the sensible thing (😄).

[ZachCallear]

I agree with you at least that Prettier ought to use parentheses to disambiguate operator precedence like "&&", "||", and the arithmetic operators.

[boris-petrov]

Actually, now that I think about it, the first line is obviously fine so ignore it. The second line is the one I've got a problem with. 😄