reorder tests

Author: jhspetersson

src/test/java/io/github/jhspetersson/packrat/AtLeastOrderBugTest.java

@@ -43,4 +43,20 @@ public void atLeastSingleValueTest() {
         var result = numbers.gather(Packrat.atLeast(3)).toList();
         assertEquals(List.of(1, 1, 1), result);
     }
+
+    @Test
+    void atLeastShouldPreserveOriginalOrder() {
+        var result = Stream.of("a", "b", "a", "b")
+                .gather(Packrat.atLeast(2))
+                .toList();
+        assertEquals(List.of("a", "b", "a", "b"), result);
+    }
+
+    @Test
+    void atLeastShouldPreserveOrderWithThreeGroups() {
+        var result = Stream.of("x", "y", "z", "x", "y", "z")
+                .gather(Packrat.atLeast(2))
+                .toList();
+        assertEquals(List.of("x", "y", "z", "x", "y", "z"), result);
+    }
 }

src/test/java/io/github/jhspetersson/packrat/AtLeastTest.java

@@ -62,4 +62,20 @@ public void atMostByTest() {
         var expected = Set.of("date", "elderberry", "fig");
         assertEquals(result, expected);
     }
+
+    @Test
+    void atMostShouldPreserveOriginalOrder() {
+        var result = Stream.of("a", "b", "a", "b")
+                .gather(Packrat.atMost(2))
+                .toList();
+        assertEquals(List.of("a", "b", "a", "b"), result);
+    }
+
+    @Test
+    void atMostShouldPreserveOrderWithUniqueElements() {
+        var result = Stream.of("cherry", "apple", "banana", "date")
+                .gather(Packrat.atMost(1))
+                .toList();
+        assertEquals(List.of("cherry", "apple", "banana", "date"), result);
+    }
 }

src/test/java/io/github/jhspetersson/packrat/AtMostOrderBugTest.java

@@ -2,6 +2,7 @@
 
 import org.junit.jupiter.api.Test;
 
+import java.util.List;
 import java.util.Locale;
 import java.util.stream.Stream;
 
@@ -76,4 +77,33 @@ public void sentencesWithLocaleTest() {
         var sentencesFR = Stream.of(FRENCH_TEXT).gather(Packrat.sentences(Locale.FRANCE)).toList();
         assertEquals(2, sentencesFR.size());
     }
+
+    @Test
+    void wordsSameInstanceInPipelineShouldNotCorrupt() {
+        var g = Packrat.words();
+        var result = Stream.of("hello world")
+                .gather(g)
+                .gather(g)
+                .toList();
+        assertEquals(List.of("hello", "world"), result);
+    }
+
+    @Test
+    void wordsSameInstanceUsedSequentiallyShouldProduceSameResults() {
+        var g = Packrat.words();
+        var result1 = Stream.of("hello world").gather(g).toList();
+        var result2 = Stream.of("foo bar baz").gather(g).toList();
+        assertEquals(List.of("hello", "world"), result1);
+        assertEquals(List.of("foo", "bar", "baz"), result2);
+    }
+
+    @Test
+    void sentencesSameInstanceInPipelineShouldNotCorrupt() {
+        var g = Packrat.sentences();
+        var result = Stream.of("Hello world. Goodbye world.")
+                .gather(g)
+                .gather(g)
+                .toList();
+        assertEquals(List.of("Hello world. ", "Goodbye world."), result);
+    }
 }

src/test/java/io/github/jhspetersson/packrat/AtMostTest.java

@@ -71,4 +71,37 @@ public void dropLastZeroTest() {
 
         assertEquals(List.of(0, 1, 2, 3, 4), after);
     }
+
+    @Test
+    void dropLastWithStreamLargerThanInternalBuffer() {
+        var result = IntStream.range(0, 20).boxed()
+                .gather(Packrat.dropLast(3))
+                .toList();
+
+        assertEquals(17, result.size());
+        assertEquals(0, result.getFirst());
+        assertEquals(16, result.getLast());
+    }
+
+    @Test
+    void dropLastWithStreamMuchLargerThanBuffer() {
+        var result = IntStream.range(0, 100).boxed()
+                .gather(Packrat.dropLast(5))
+                .toList();
+
+        assertEquals(95, result.size());
+        assertEquals(0, result.getFirst());
+        assertEquals(94, result.getLast());
+    }
+
+    @Test
+    void dropLastLargeNWithLargerStream() {
+        var result = IntStream.range(0, 50).boxed()
+                .gather(Packrat.dropLast(20))
+                .toList();
+
+        assertEquals(30, result.size());
+        assertEquals(0, result.getFirst());
+        assertEquals(29, result.getLast());
+    }
 }

src/test/java/io/github/jhspetersson/packrat/BreakingGathererReuseBugTest.java

@@ -2,7 +2,9 @@
 
 import org.junit.jupiter.api.Test;
 
+import java.util.Arrays;
 import java.util.List;
+import java.util.function.Function;
 import java.util.stream.Stream;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -102,4 +104,39 @@ record Person(String name, String id) {}
             List.of(new Person("David", "C345"), new Person("Eve", "c678"))
         ), result);
     }
+
+    @Test
+    void equalChunksWithNullElements() {
+        var result = Stream.<Integer>of(null, null, 1, 1)
+                .gather(Packrat.equalChunksBy(Function.identity()))
+                .toList();
+        assertEquals(List.of(Arrays.asList(null, null), List.of(1, 1)), result);
+    }
+
+    @Test
+    void equalChunksWithNullInLastChunk() {
+        var result = Stream.<Integer>of(1, 1, null, null)
+                .gather(Packrat.equalChunksBy(Function.identity()))
+                .toList();
+        assertEquals(List.of(List.of(1, 1), Arrays.asList(null, null)), result);
+    }
+
+    @Test
+    void equalChunksSingleNullChunk() {
+        var result = Stream.<Integer>of((Integer) null)
+                .gather(Packrat.equalChunksBy(Function.identity()))
+                .toList();
+        assertEquals(List.of(Arrays.asList((Integer) null)), result);
+    }
+
+    @Test
+    void equalChunksGathererShouldBeReusable() {
+        var gatherer = Packrat.<Integer>equalChunks();
+
+        var result1 = Stream.of(1, 1, 2, 2).gather(gatherer).toList();
+        assertEquals(List.of(List.of(1, 1), List.of(2, 2)), result1);
+
+        var result2 = Stream.of(1, 1, 2, 2).gather(gatherer).toList();
+        assertEquals(List.of(List.of(1, 1), List.of(2, 2)), result2);
+    }
 }