Skip to content

Allow configuration of text similarity threshold and improve default#799

Open
zmbc wants to merge 4 commits intojupyter:mainfrom
zmbc:text_similarity_config
Open

Allow configuration of text similarity threshold and improve default#799
zmbc wants to merge 4 commits intojupyter:mainfrom
zmbc:text_similarity_config

Conversation

@zmbc
Copy link
Copy Markdown

@zmbc zmbc commented Jan 31, 2026

Addresses #785.

Note that I have conservatively made this change only affect the comparison of cell sources. I think you could make an argument that an analogous change for outputs would also be good, but that would have had much larger impacts on the test suite.

@Carreau
Copy link
Copy Markdown
Member

Carreau commented Feb 5, 2026

generally +1 on this, maybe some small refactor and make sure we don't change API.

@zmbc
Copy link
Copy Markdown
Author

zmbc commented Feb 12, 2026

@Carreau I believe I've addressed all your comments!

@zmbc
Copy link
Copy Markdown
Author

zmbc commented Mar 13, 2026

@krassowski @Carreau what is the next step to move this forward?

@Carreau Carreau requested a review from krassowski March 16, 2026 12:44
@Carreau
Copy link
Copy Markdown
Member

Carreau commented Mar 16, 2026

Thanks for your patience, unfortunately the blocking part if maintainer time; I've reaproved the workflow; and thanks for the ping. It might take me some time to get back to it as my actual day-time job takes priority and I have few hours to consecrate to open-source outside of that.

@zmbc
Copy link
Copy Markdown
Author

zmbc commented Mar 16, 2026

@Carreau totally understand. Are you open to onboarding new maintainers?

It looks like this PR isn't working on Python 3.8 which is 1.5 years past EOL. Are you open to a PR to remove 3.8 (and 3.9) support?

@Carreau
Copy link
Copy Markdown
Member

Carreau commented Mar 17, 2026

Personally yes, but this would have to pass other maintainers as well. But I think it make sens.

@Carreau
Copy link
Copy Markdown
Member

Carreau commented Mar 17, 2026

limiting to 3.6 was done as of 83a768f; which was 3 years ago so I think moving to 3.10+ is reasonable.

@Carreau
Copy link
Copy Markdown
Member

Carreau commented Mar 17, 2026

and #802 has some discussion where @krassowski is ok droping up to 3.8 (included); so 3.9 is on the edge.

@zmbc
Copy link
Copy Markdown
Author

zmbc commented Mar 17, 2026

Ah, thanks for that context. It looks like 3.8 was still included on Windows in error -- I've removed that now.

@zmbc
Copy link
Copy Markdown
Author

zmbc commented Mar 17, 2026

The other failing workflow was the "check release" one, with this error:

 M package-lock.json

Traceback (most recent call last):
  File "/home/runner/work/nbdime/nbdime/.jupyter_releaser_checkout/scripts/bump_version.py", line 110, in <module>
    bump(args.force, args.spec)
  File "/home/runner/work/nbdime/nbdime/.jupyter_releaser_checkout/scripts/bump_version.py", line 68, in bump
    raise Exception("Must be in a clean git state with no untracked files")
Exception: Must be in a clean git state with no untracked files

I'm having a hard time understanding what is going on here, and I'm wondering if it has something to do with the fact that this PR is from a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants