getting started: AttributeError: 'IsolateDef' object has no attribute 'create_isolate'

[glycerine]

Using python 3.10 I think I got most of the way through the install, by using
a venv and doing python3 setup.py develop;

I am able to run ivy_check, however the getting started ivy command fails with

  File "/mnt/oldrog/home/jaten/pyivy/ivy/ivy/ivy_compiler.py", line 2252, in ivy_compile
    iso.create_isolate(isolate.get(),mod,**kwargs)
AttributeError: 'IsolateDef' object has no attribute 'create_isolate'

complete traceback:

(venv) jaten@rog ~/pyivy/ivy/doc/examples (master) $ ivy_check trace=true client_server_example_new.ivy

Isolate this:

    The inductive invariant consists of the following conjectures:
        client_server_example_new.ivy: line 26: invar4

    The following action implementations are present:
        client_server_example_new.ivy: line 14: implementation of connect
        client_server_example_new.ivy: line 20: implementation of disconnect

    The following initializers are present:
        client_server_example_new.ivy: line 9: init[after1]

    Initialization must establish the invariant
        client_server_example_new.ivy: line 26: invar4 ... PASS

    The following set of external actions must preserve the invariant:
        (internal) ext:connect
            client_server_example_new.ivy: line 26: invar4 ... FAIL
searching for a small model... done
[
    @X = 0
    @Y = 0
    @Z = 1
    semaphore(0) = true
    link(0,0) = true
    link(1,0) = false
]
call connect

{
    [
        fml:x = 1
        fml:y = 0
    ]
client_server_example_new.ivy: line 15: 
    assume [asrt2] semaphore(fml:y)

client_server_example_new.ivy: line 16: 
    link(fml:x,fml:y) := true

    [
        link(1,0) = true
    ]
client_server_example_new.ivy: line 17: 
    semaphore(fml:y) := false

    [
        semaphore(0) = false
    ]
}


(venv) jaten@rog ~/pyivy/ivy/doc/examples (master) $ ivy client_server_example.ivy
Traceback (most recent call last):
  File "/mnt/oldrog/home/jaten/pyivy/venv/bin/ivy", line 33, in <module>
    sys.exit(load_entry_point('ms-ivy', 'console_scripts', 'ivy')())
  File "/mnt/oldrog/home/jaten/pyivy/ivy/ivy/ivy.py", line 14, in main
    ui_main_loop(ivy_init())
  File "/mnt/oldrog/home/jaten/pyivy/ivy/ivy/ivy_init.py", line 106, in ivy_init
    source_file(fn,f,**skwargs)
  File "/mnt/oldrog/home/jaten/pyivy/ivy/ivy/ivy_init.py", line 72, in source_file
    ivy_load_file(f,**kwargs)
  File "/mnt/oldrog/home/jaten/pyivy/ivy/ivy/ivy_compiler.py", line 2314, in ivy_load_file
    ivy_compile(decls,**kwargs)
  File "/mnt/oldrog/home/jaten/pyivy/ivy/ivy/ivy_compiler.py", line 2252, in ivy_compile
    iso.create_isolate(isolate.get(),mod,**kwargs)
AttributeError: 'IsolateDef' object has no attribute 'create_isolate'
(venv) jaten@rog ~/pyivy/ivy/doc/examples (master) $ python3 --version
Python 3.10.18
(venv) jaten@rog ~/pyivy/ivy/doc/examples (master) $ uname -a
Linux rog 6.11.0-26-generic #26~24.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Apr 17 19:20:47 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
(venv) jaten@rog ~/pyivy/ivy/doc/examples (master) $

[glycerine]

I think this is just shadowing bug, due to re-use of the name "iso" as a variable at line 2239; https://github.com/kenmcmil/ivy/blob/master/ivy/ivy_compiler.py#L2239

(venv) jaten@rog ~/pyivy/ivy/doc/examples (master) $ git diff
diff --git a/ivy/ivy_compiler.py b/ivy/ivy_compiler.py
index 702456c..18193a1 100644
--- a/ivy/ivy_compiler.py
+++ b/ivy/ivy_compiler.py
@@ -2236,9 +2236,9 @@ def ivy_compile(decls,mod=None,create_isolate=True,**kwargs):
                 pp,pc = iu.parent_child_name(p)
                 if pp == 'this' or iu.compose_names(pp,'global') not in im.module.\
attributes:
                     global_objects.append(ivy_ast.Atom(p,[]))
-        for iso in list(im.module.isolates.values()):
-            iso.args += tuple(global_objects)
-            iso.with_args += len(global_objects)
+        for iso1 in list(im.module.isolates.values()):
+            iso1.args += tuple(global_objects)
+            iso1.with_args += len(global_objects)


         create_sort_order(mod)

seems to allow me to get to the next issue (below). I'll have to setup an X11 environment I guess? Does IVy work fine without out; say under emacs?

Thank you.

$ ivy client_server_example.ivy
Traceback (most recent call last):
  File "/mnt/oldrog/home/jaten/pyivy/venv/bin/ivy", line 33, in <module>
    sys.exit(load_entry_point('ms-ivy', 'console_scripts', 'ivy')())
  File "/mnt/oldrog/home/jaten/pyivy/ivy/ivy/ivy.py", line 14, in main
    ui_main_loop(ivy_init())
  File "/mnt/oldrog/home/jaten/pyivy/ivy/ivy/tk_ui.py", line 318, in ui_main_loop
    new_ui()
  File "/mnt/oldrog/home/jaten/pyivy/ivy/ivy/tk_ui.py", line 314, in new_ui
    ivy_ui.ui = tkui_class()
  File "/mnt/oldrog/home/jaten/pyivy/ivy/ivy/tk_ui.py", line 45, in __init__
    tk = tkinter.tix.Tk()
  File "/usr/lib/python3.10/tkinter/tix.py", line 210, in __init__
    tkinter.Tk.__init__(self, screenName, baseName, className)
  File "/usr/lib/python3.10/tkinter/__init__.py", line 2302, in __init__
    self.tk = _tkinter.create(screenName, baseName, className, interactive, wantobj\
ects, useTk, sync, use)
_tkinter.TclError: no display name and no $DISPLAY environment variable

[glycerine]

So this is a duplicate of #44

and the corresponding trivial PR which has been left unmerged for 6 months at this point

#86