Notification activation should not block downloads

[kelson42]

But it seems to be the case in version 3.14. To be confirmed and fixed.

See

[atharvyadav22]

Hello please assign me this, i'll inspect this issue maybe in OnlineLibraryFragment as downloads are handled there according to my study.

[MohitMaliFtechiz]

@kelson42 Seeing the comment, it is for the notification permission we are asking for before downloading the content. On Android 13 and above, it is mandatory to give the notification permission for downloading the content so that we can show the ongoing download notification and download the book in the background. Because we have to show a notification for a foreground service.

If we don't ask for the notification permission or make it optional(and the user does not allow it), then background downloading will be affected on Android 13 and above.

[atharvyadav22]

@kelson42 @MohitMaliFtechiz i have found the issue but even if i solve , it will be an regression error as there is Migration for that Fragment as well download notification pr so to avoid it we should migrate it first

[MohitMaliFtechiz]

@atharvyadav22 Let's keep this one open. It needs discussion before doing anything. It will affect background downloading. So the proper discussion is a must before doing anything.

[atharvyadav22]

@atharvyadav22 Let's keep this one open. It needs discussion before doing anything. It will affect background downloading. So the proper discussion is a must before doing anything.

actually that download code ignores lower android version so it doesn't affect notifications and download there but for Android 13+ its logic is such that notification is needed to download in that if logic.
So we should consider this too in Migration of that fragment.
So whosoever is having that fragment I'll reach out and ask them if any help is needed.

[atharvyadav22]

the new Issues now opened can only be solved after migration as they'll again be reintroduce later if i can help in these I'll be happy if you assign me some task.

[MohitMaliFtechiz]

actually that download code ignores lower android version so it doesn't affect notifications and download there but for Android 13+ its logic is such that notification is needed to download in that if logic.

It is because notification permission was introduced in Android 13; below that, we don't need that permission. So, the download can easily work below Android 13.

So we should consider this too in Migration of that fragment.

Not yet agreed on implementing this directly without any clear workaround or informing the users about it. That background download will not work without this permission. Otherwise, we will face some comments and tickets regarding this(Background download is not working).

[atharvyadav22]

yes agree

[harshsomankar123-tech]

@MohitMaliFtechiz I agree with your point. Since notification permission is required for foreground services on Android 13+, it’s better to discuss the proper approach before implementing a fix.

[MohitMaliFtechiz]

@harshsomankar123-tech, @atharvyadav22 Thank you for understanding my point. We will discuss this after the compose migration is done. I request you both to focus on migration tickets and PRs. If your PRs need my review/suggestions, just drop a comment there, and I will take that as top priority.