dangerous SC2164 recommendation

[mcandre]

ShellCheck provides toxic advice for cd customization lines, for example in .zshrc configuration files.

SC2164 insists on triggering exit or return when change directory fails. Wouldn't exit force the entire shell session to terminate?

Frankly, cd has its own exit codes. Why not simply allow those to propagate normally, instead of trying to wrap cd's exit codes in inherently worse error handling code?

[brother]

You do not need to follow the suggestions, in some cases it is hard to cover every possible usage. When shellcheck want your attention on something you can determine if the case fits not and then either take an action or ignore the warning with a directive. If the suggestion is totally wrong that should ofc be addrressed with a bug report in this very repo.