We already have a counter launcher.restart that tracks when launcher shuts down. However, if launcher panics, it may not be able to ship the updated launcher.restart count prior to shutdown -- so to accurately track how often launcher is restarting, we should also add a new counter launcher.startup that fires on launcher startup instead. If we see a discrepancy between these two counters, or a spike in launcher.startup, we may be able to identify panics or fatal errors in a release.
This new counter should fire somewhere at the start of Execute, once we're sure we've added all necessary attributes and are ready to ship metrics. We should ensure that this new counter does not fire when the agent flags change (i.e., we shouldn't put this counter inside setNewGlobalProvider).
We already have a counter
launcher.restartthat tracks when launcher shuts down. However, if launcher panics, it may not be able to ship the updatedlauncher.restartcount prior to shutdown -- so to accurately track how often launcher is restarting, we should also add a new counterlauncher.startupthat fires on launcher startup instead. If we see a discrepancy between these two counters, or a spike inlauncher.startup, we may be able to identify panics or fatal errors in a release.This new counter should fire somewhere at the start of
Execute, once we're sure we've added all necessary attributes and are ready to ship metrics. We should ensure that this new counter does not fire when the agent flags change (i.e., we shouldn't put this counter insidesetNewGlobalProvider).