Issues on RC8.5

[Richhoef]

First of all, thanks for your hard work on this very nice project!

Below are the issues I found on RC8.5:

• The start/end values in the visibility window (in the page settings) aren't saved
• The device power and refresh settings (and epaper options) aren't saved
• The hourly widget does not show any values
• In the designer, when a text box (for example, the date/time box) is made very narrow, but high, the text is shown wrapped, but on my device, the text will still be one line (therefore going wider than the box I set and drawing over other items)
• The stay_awake_switch is checked twice in deep_sleep_cycle. Once at the top (after which a return out of the script is done) and once at the bottom (after which a retry of the script after 60 seconds is done, although this point will of course never be reached). I think the one at the top should go.
• It always does “Auto-switching to scheduled page” because of the id(last_page_switch_time) == 0 (and last_page_switch_time being initialized with 0). It isn't really in the way, but looks a bit weird in the log, because there is no switching required.
• Nothing is done with is_sleep_time in manage_run_and_sleep so that part could go. Same for interval, it is set at the top, but never changed.
• No long sleep (with sleep until is implemented when sleep_time is active. I think this should be in the deep_sleep_cycle and look something like this (and should be situated inside the "Entering Deep Sleep now..." section):

      - logger.log: "Entering Deep Sleep now..."
      - if:
          condition:
            binary_sensor.is_off: stay_awake_switch
          then:
            - if:
                condition:
                  lambda: |-
                    auto time = id(ha_time).now();
                    if (time.is_valid()) {
                      int hour = time.hour;
                      int start = 23;
                      int end = 7;
                      if (start < end) {
                        if (hour >= start && hour < end) return true; // long sleep time
                      } else if (start > end) {
                        if (hour >= start || hour < end) return true; // long sleep time
                      }
                    }
                    return false; // short sleep time
                then:
                  - logger.log: "It is nighttime, sleep until 07:00."
                  - deep_sleep.enter:
                      id: deep_sleep_control
                      until: "07:00:00"
                      time_id: ha_time
                else:
                  - logger.log: "Daytime, normal cycle"
                  - deep_sleep.enter: deep_sleep_control
          else:
            - logger.log: "Deep Sleep prevented, retrying in 60s"
            - delay: 60s
            - script.execute: deep_sleep_cycle

[Richhoef]

@koosoli, In the 9.0 release you mentioned that "The visibility/device-setting round-trip and hourly weather population portions are already covered by the RC8.x fixes." except, I still did not get any values on the hourly weather widget, so I looked into it and I found out, the names don't match up. The template sensor is named "Weather Forecast Hour 0900" (with unique_id weather_forecast_hour_0900_high), but the sensor in esphome looks for sensor.weather_forecast_hour_0900_high. And the entity_id Home Assistant makes comes from the name of the template sensor, not the unique ID, so the entities did not match and no data was retreived by my device. With this fix (adding High to the name) the hourly weather widget works.

Also, the visibility /device-settings still aren't saved for me (I use the designer on Home Assistant). This is true both when accessed via homeassistant.local and via nabu casa. It also still persists after deleting the cookies.

Now some issues found on RC9.1:

• The corners (at least for the rectangle and the calendar) are not rounded, when set to be rounded. In the designer they are shown rounded, but on my device, they have sharp, 90 degree, corners.
• My device doesn't stay on with the stay awake switch, because the default deep_sleep is not prevented (by deep_sleep.prevent) after a software update. The deep_sleep.allow after the 90s delay cancels the earlier deep_sleep.prevent. I think deep_sleep.prevent should be added just below - logger.log: "Deep Sleep prevented, retrying in 60s". Then this issue is resolved.
• In my opinion, - delay: 5s should always be called to give the sensors time to update. So not just when lambda: 'return !(id(ha_time).now().is_valid() && api_is_connected());' Otherwise, not all sensors may be done updating when the screen is updated.
• The global last_touch_time is now generated (but not used for my device).
• All the Some issues (except for the datetime text, which you explained) from my earlier message in this thread still persist.

[koosoli]

thanks, will have another go at all of this for the upcoming version RC10

[Richhoef]

@koosoli, I looked at RC9.2 and the date does not wrap around to the next line any more. My small box did hide part of the date in the Designer (while on the device the whole date is shown regardless of the width of the box). Maybe the date(/time) shouldn't have a box around it that can be resized? It's an all or nothing, also on the device. Don't know if that is possible. If not, the current behaviour would be perfectly acceptable, in my opinion.

Also, I now get this error:

/config/esphome/seeedstudio.yaml: In lambda function:
/config/esphome/seeedstudio.yaml:777:22: error: conflicting declaration 'auto draw_rrect_border'
  777 |                   auto draw_rrect_border = [&](int x, int y, int w, int h, int r, int t, auto c) {
      |                      ^~~~~~~~~~~~~~~~~
/config/esphome/seeedstudio.yaml:371:22: note: previous declaration as 'setup()::<lambda(esphome::display::Display&)>::<lambda(int, int, int, int, int, int, auto:12)> draw_rrect_border'
  371 |                   auto draw_rrect_border = [&](int x, int y, int w, int h, int r, int t, auto c) {
      |                      ^~~~~~~~~~~~~~~~~
/config/esphome/seeedstudio.yaml:1104:22: error: conflicting declaration 'auto draw_rrect_border'
 1104 |                   auto draw_rrect_border = [&](int x, int y, int w, int h, int r, int t, auto c) {
      |                      ^~~~~~~~~~~~~~~~~
/config/esphome/seeedstudio.yaml:371:22: note: previous declaration as 'setup()::<lambda(esphome::display::Display&)>::<lambda(int, int, int, int, int, int, auto:12)> draw_rrect_border'
  371 |                   auto draw_rrect_border = [&](int x, int y, int w, int h, int r, int t, auto c) {
      |                      ^~~~~~~~~~~~~~~~~
*** [.pioenvs/seeedstudio/src/main.cpp.o] Error 1

The scope delimiting { and } are missing around it, so it is declared multiple times within the same scope (this seems to be the case for the normal Rectangle when you later give it rounded corners).

And I have edited my previous posts in this issue and crossed out the things that are fixed now (see below).
Fixed:

• The device settings are now saved again (the visibily settings however (the hours from/to a page should be visible) are still not saved)
• The Hourly widget now shows values (I think users should manually recreate the entity IDs to update the entity ID to the correct name (Settings -> Devices & services -> Entities -> [select entities] -> [pick option "Recreate entity IDs of selected"]) after they made the name change and restarted HA, but I am not 100% sure).
• The corners are now rounded (with the above mentioned error message that is resolved after limiting the scope)
• The deep sleep is now also correctly prevented after a device flash.

[koosoli]

Just did some more work on this, please have a look. You will need to install it manually as not all updates made it into RC10

v1.0.0-rc.10...main

[Richhoef]

I only got to look at it this evening, so I could skip RC10 and go straigt to RC11:

• The visibility window is now saved correctly in the designer.
• The stay awake switch is now only checked once, so that is correct.
• The auto-switching value is gone.
• The last_touch_time is gone.
• The 5s delay is done very elegantly now.
• I like how the view of the date/time widget now represents the on device behaviour.

This now only leaves the last 2 points from the first message in this issue open (I have edited my previous posts and crossed out what has been fixed).
Also, the language selection for the weather widget is awesome!! Would really like that for the calendar and date/time widget as well, if possible.

Thanks again for all your dedication and time in this awesome project!