Skip to content

feat: improve extraManifests #369

Description

@wizarden1

Describe the feature

Currently extraManifests suppot only plain text yaml and doesn't support helm variables and blocks
It support:

  - apiVersion: v1
    kind: Secret
    metadata:
      name: "langfuse"
    type: Opaque
    stringData:
      redis-password: "password"
      clickhouse-password: "password"
      postgresql-password: "password"
      nextauth-secret: "password"

and not support:

  - apiVersion: v1
    kind: Secret
    metadata:
      name: "{{ include "langfuse.fullname" . }}"
      namespace: {{ $.Release.Namespace }}
      labels:
        {{- include "langfuse.labels" . | nindent 4 }}
    type: Opaque
    stringData:
      redis-password: "password"
      clickhouse-password: "password"
      postgresql-password: "password"
      nextauth-secret: "password"

Use cases

for example like that:

  - apiVersion: keda.sh/v1alpha1
    kind: ScaledObject
    metadata:
      name: {{ include "langfuse.fullname" . }}-worker
      namespace: {{ $.Release.Namespace }}
      labels:
        {{- include "langfuse.labels" . | nindent 4 }}
    spec:
      scaleTargetRef:
        name: {{ include "langfuse.fullname" . }}-worker
      minReplicaCount: {{ .Values.langfuse.worker.keda.minReplicas }}
      maxReplicaCount: {{ .Values.langfuse.worker.keda.maxReplicas }}
      pollingInterval: {{ .Values.langfuse.worker.keda.pollingInterval }}
      cooldownPeriod: 60
      triggers:
        - type: redis
          metadata:
            host: {{ .Values.redis.host }}
            port: '{{ .Values.redis.port }}'
            username: {{ .Values.redis.auth.username }}
            passwordFromEnv: "REDIS_PASSWORD"
            listName: "langfuse:tasks:wait"
            listLength: '{{ .Values.langfuse.worker.keda.taskqueuelength }}'
            enableTLS: "true"

Additional information

Necessary to do:
in files 'extra-manifests.yaml'

{{- range .Values.extraManifests }}
---
{{ toYaml . }}
{{- end }}

replace to:

{{- range .Values.extraManifests }}
---
{{ tpl . $ }}
{{- end }}

Are you interested to contribute this feature?

No

Metadata

Metadata

Assignees

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions