Skip to content

Commit 7c92ce7

Browse files
committed
wip(screen_retriever_ffi): Remove unnecessary __OBJC__ definitions
1 parent 9d13c1e commit 7c92ce7

6 files changed

Lines changed: 7 additions & 23 deletions

File tree

packages/screen_retriever_ffi/example/macos/Podfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ EXTERNAL SOURCES:
1515

1616
SPEC CHECKSUMS:
1717
FlutterMacOS: 8f6f14fa908a6fb3fba0cd85dbd81ec4b251fb24
18-
screen_retriever_ffi: a709a16c7c8d844e0516379dfbccbe0ef7eb6c76
18+
screen_retriever_ffi: 27e5f36a0be0b643507d89951f561e0fb0119847
1919

2020
PODFILE CHECKSUM: 7eb978b976557c8c1cd717d8185ec483fd090a82
2121

packages/screen_retriever_ffi/lib/screen_retriever_ffi_bindings_generated.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,5 +168,3 @@ final class CursorPoint extends ffi.Struct {
168168
@ffi.Double()
169169
external double y;
170170
}
171-
172-
const int __OBJC__ = 1;

packages/screen_retriever_ffi/macos/Classes/screen_retriever_ffi.mm

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
// Relative import to be able to reuse the C sources.
22
// See the comment in ../screen_retriever_ffi.podspec for more information.
33

4-
// Make sure __OBJC__ is defined before including other files
5-
#ifndef __OBJC__
6-
#define __OBJC__ 1
7-
#endif
8-
94
// Import Cocoa framework
105
#import <Cocoa/Cocoa.h>
116

packages/screen_retriever_ffi/macos/screen_retriever_ffi.podspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ A new Flutter FFI plugin project.
3838
'CLANG_ENABLE_OBJC_ARC' => 'YES',
3939
'CLANG_CXX_LANGUAGE_STANDARD' => 'c++17',
4040
'CLANG_CXX_LIBRARY' => 'libc++',
41-
'OTHER_CPLUSPLUSFLAGS' => '-std=c++17 -D__OBJC__=1',
41+
'OTHER_CPLUSPLUSFLAGS' => '-std=c++17',
4242
# Enable Objective-C++ compilation for .cpp files
43-
'OTHER_CFLAGS' => '-DOBJC_OLD_DISPATCH_PROTOTYPES=0 -D__OBJC__=1',
44-
'GCC_PREPROCESSOR_DEFINITIONS' => '$(inherited) __OBJC__=1',
43+
'OTHER_CFLAGS' => '-DOBJC_OLD_DISPATCH_PROTOTYPES=0',
44+
'GCC_PREPROCESSOR_DEFINITIONS' => '$(inherited)',
4545
'MACOSX_DEPLOYMENT_TARGET' => '10.11'
4646
}
4747
s.swift_version = '5.0'

packages/screen_retriever_ffi/src/screen_retriever_macos.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@
33
#include <iostream>
44
#include "screen_retriever.h"
55

6-
// Force __OBJC__ to be defined if not already
7-
#ifndef __OBJC__
8-
#define __OBJC__ 1
9-
#endif
10-
116
// Import Cocoa headers
127
#import <Cocoa/Cocoa.h>
138

packages/screen_retriever_ffi/src/screen_retriever_macos.mm

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@
33
#include <iostream>
44
#include <string>
55

6-
// Force __OBJC__ to be defined if not already
7-
#ifndef __OBJC__
8-
#define __OBJC__ 1
9-
#endif
10-
116
// Import Cocoa headers
127
#import <Cocoa/Cocoa.h>
138

@@ -54,8 +49,9 @@
5449
NSArray<NSScreen*>* screens = [NSScreen screens];
5550
bool isFirstScreen = true;
5651

57-
displayList.displays = new Display[screens.count];
58-
displayList.count = screens.count;
52+
int count = (int) screens.count;
53+
displayList.displays = new Display[count];
54+
displayList.count = count;
5955
int index = 0;
6056
for (NSScreen* screen in screens) {
6157
displayList.displays[index] = CreateDisplayFromNSScreen(screen, isFirstScreen);

0 commit comments

Comments
 (0)