Bug in SUNLogger_SetXFilename?

[MichaelClerx]

Hi all,

In sundials 6 and earlier, I could suppress (expected) warning messages to stdout/stderr (in code, using a precompiled sundials library) with a custom error handler. With the new logging system, it seems like the only way to do this is to pipe warnings to a temporary file?

Loggers created through SUNLogger_Create

sundials/src/sundials/sundials_logger.c

Line 141 in c8dabce

SUNErrCode SUNLogger_Create(SUNComm comm, int output_rank, SUNLogger* logger_ptr)

have warnings and errors going to stdout and stderr by default

sundials/src/sundials/sundials_logger.c

Lines 170 to 171 in c8dabce

	logger->error_fp = stderr;
	logger->warning_fp = stdout;

and calling SUNLogger_SetWarningFilename with NULL or an empty string does not change this:

sundials/src/sundials/sundials_logger.c

Line 258 in c8dabce

if (warning_filename && strcmp(warning_filename, ""))

I think this contradicts the manual, which states:

To disable output for one of the streams, then do not set the environment variable, or set it to an empty string.

But this would just cause a call with an empty string, which would just be ignored by SUNLogger_SetWarningFilename etc. again.

Am I missing something, or is this a bug in the SUNLogger_SetXFilename methods?

Best wishes,
Michael

[balos1]

Hi @MichaelClerx. Thanks for reporting this issue. It was our intent to allow the output to be disabled with an empty string. This should be fixed by #860.