Fixing Visual Studio 2019 build

Author: luau-project

LuaInstaller.Core/VisualStudioVersionsFromSetupApi.cs

@@ -29,7 +29,7 @@ private VisualStudioVersion ProcessSetupInstance(ISetupInstance2 setupInstance)
 				ISetupPackageReference packageReference = packageReferences[i];
 				string id = packageReference.GetId();
 
-				if (id.Equals("Microsoft.VisualCpp.Tools.Common.Utils", StringComparison.InvariantCultureIgnoreCase))
+				if (id.Equals("Microsoft.VisualCpp.DIA.SDK", StringComparison.InvariantCultureIgnoreCase))
 				{
 					Match match = _rgx.Match(setupInstance.GetInstallationVersion());
 

appveyor.ps1

@@ -1,4 +1,7 @@
 $dotnet_dir = Join-Path -Path (Get-Location) -ChildPath "dotnet_dir";
+
+New-Item $dotnet_dir -ItemType Directory;
+
 $dotnet_install_file = Join-Path -Path $dotnet_dir -ChildPath "dotnet-install.ps1";
 $dotnet_runner = Join-Path -Path $dotnet_dir -ChildPath "dotnet";
 
@@ -8,13 +11,19 @@ Invoke-WebRequest -Uri 'https://dot.net/v1/dotnet-install.ps1' -UseBasicParsing
 $archs = 'x64', 'x86';
 
 foreach ($arch in $archs) {
-    Remove-Item .\LuaInstaller.Console\bin, .\LuaInstaller.Console\obj, .\LuaInstaller\bin, .\LuaInstaller\obj -Recurse;
+    $directories_to_clean = ".\LuaInstaller.Console\bin", ".\LuaInstaller.Console\obj", ".\LuaInstaller\bin", ".\LuaInstaller\obj";
+
+    foreach ($dir_to_clean in $directories_to_clean) {
+        if (Test-Path $dir_to_clean) {
+            Remove-Item $dir_to_clean -Recurse;
+        }
+    }
 
     & $dotnet_runner restore LuaInstaller.sln;
     & $dotnet_runner build .\LuaInstaller.Console\LuaInstaller.Console.csproj -c Release -r win-$arch --self-contained true;
     & $dotnet_runner build .\LuaInstaller\LuaInstaller.csproj -c Release -r win-$arch --self-contained true;
 
-    $console = ".\LuaInstaller.Console\bin\Release\netcoreapp3.0\win-$arch\LuaInstaller.Console.exe";
+    $console = ".\LuaInstaller.Console\bin\Any CPU\Release\netcoreapp3.0\win-$arch\LuaInstaller.Console.exe";
 
     $commands = "/?", "list-win-sdk", "list-vs-$arch", "list-lua";
 
@@ -47,4 +56,4 @@ foreach ($arch in $archs) {
 
         Write-Host;
     }
-}
+}

appveyor.yml

@@ -1,12 +1,9 @@
 version: 1.0.{build}
-
-image: Visual Studio 2022
-
+image:
+- Visual Studio 2022
+- Visual Studio 2019
+- Visual Studio 2017
 configuration: Release
-
 platform: Any CPU
-
-install:
-- pwsh: .\appveyor.ps1
-
-build: off
+build_script:
+- pwsh: "$dotnet_dir = Join-Path -Path (Get-Location) -ChildPath \"dotnet_dir\";\n\nNew-Item $dotnet_dir -ItemType Directory;\n\n$dotnet_install_file = Join-Path -Path $dotnet_dir -ChildPath \"dotnet-install.ps1\";\n$dotnet_runner = Join-Path -Path $dotnet_dir -ChildPath \"dotnet\";\n\nInvoke-WebRequest -Uri 'https://dot.net/v1/dotnet-install.ps1' -UseBasicParsing -OutFile $dotnet_install_file;\n& $dotnet_install_file -Architecture x64 -Version \"6.0.301\" -InstallDir $dotnet_dir;\n\n$archs = 'x64', 'x86';\n\nforeach ($arch in $archs) {\n    $directories_to_clean = \".\\LuaInstaller.Console\\bin\", \".\\LuaInstaller.Console\\obj\", \".\\LuaInstaller\\bin\", \".\\LuaInstaller\\obj\";\n\n    foreach ($dir_to_clean in $directories_to_clean) {\n        if (Test-Path $dir_to_clean) {\n            Remove-Item $dir_to_clean -Recurse;\n        }\n    }\n    \n    & $dotnet_runner restore LuaInstaller.sln;\n    & $dotnet_runner build .\\LuaInstaller.Console\\LuaInstaller.Console.csproj -c Release -r win-$arch --self-contained true;\n    & $dotnet_runner build .\\LuaInstaller\\LuaInstaller.csproj -c Release -r win-$arch --self-contained true;\n\n    $console = \".\\LuaInstaller.Console\\bin\\Any CPU\\Release\\netcoreapp3.0\\win-$arch\\LuaInstaller.Console.exe\";\n\n    $commands = \"/?\", \"list-win-sdk\", \"list-vs-$arch\", \"list-lua\";\n\n    foreach ($c in $commands) {\n        Write-Host;\n        Write-Host command: $c -ForegroundColor Cyan;\n        & $console $c;\n        Write-Host;\n    }\n\n    $lua_versions = \"5.1.5\", \"5.2.4\", \"5.3.6\", \"5.4.4\";\n\n    $current_dir = Get-Location;\n\n    foreach ($lua_ver in $lua_versions) {\n        Write-Host;\n        Write-Host Installing Lua $lua_ver;\n        $lua_ver_dir = Join-Path -Path $current_dir -ChildPath $lua_ver | Join-Path -ChildPath $arch;\n\n        & $console install \"dest-dir=$lua_ver_dir\" version=$lua_ver arch=$arch;\n        \n        $lua_exe_dir = Join-Path -Path $lua_ver_dir -ChildPath 'bin';\n        $lua_exe = Join-Path -Path $lua_exe_dir -ChildPath 'lua.exe';\n        Write-Host Executable file: $lua_exe;\n\n        Write-Host;\n        Write-Host Testing Lua:\n        Write-Host;\n        & $lua_exe -v;\n\n        Write-Host;\n    }\n}"