Skip to content

Commit 87a6a10

Browse files
majorsilencemajorsilence
committed
Refactor RunGetData calls to remove null parameter
1 parent 0ceb4a0 commit 87a6a10

15 files changed

Lines changed: 31 additions & 26 deletions

File tree

‎Examples/BarcodeShowcase/Program.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
return 1;
3131
}
3232

33-
await report.RunGetData(null);
33+
await report.RunGetData();
3434

3535
var ofs = new OneFileStreamGen(outPath, true);
3636
await report.RunRender(ofs, OutputPresentationType.PDF);

‎Examples/ExportMultipleFormats/Program.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
}
3333

3434
// Query the database exactly once
35-
await report.RunGetData(null);
35+
await report.RunGetData();
3636

3737
// Render to each format from the same in-memory data
3838
var formats = new[]

‎Examples/ExportSqliteToPdf/Program.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
return 1;
3535
}
3636

37-
await report.RunGetData(null);
37+
await report.RunGetData();
3838

3939
var ofs = new OneFileStreamGen(outPath, true);
4040
await report.RunRender(ofs, OutputPresentationType.PDF);

‎Examples/JsonToPdf/Program.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
return 1;
3535
}
3636

37-
await report.RunGetData(null);
37+
await report.RunGetData();
3838

3939
var ofs = new OneFileStreamGen(outPath, true);
4040
await report.RunRender(ofs, OutputPresentationType.PDF);

‎Examples/ProductQrCodes/Program.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
return 1;
3333
}
3434

35-
await report.RunGetData(null);
35+
await report.RunGetData();
3636

3737
var ofs = new OneFileStreamGen(outPath, true);
3838
await report.RunRender(ofs, OutputPresentationType.PDF);

‎Majorsilence.Reporting.Benchmarks/JsonDataProviderBenchmark.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public async Task NestedJson()
3232
"columns=EmployeeID,LastName,FirstName,ContactInfo_Phone,ContactInfo_Email",
3333
pageHeaderText: "DataProviderTest TestMethod1");
3434
using var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
35-
await fyiReport.RunGetData(null);
35+
await fyiReport.RunGetData();
3636
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.PDF);
3737
}
3838
}

‎RdlCreator.Tests/Reports_ChainedTest.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public async Task PdfStreamExport()
3535

3636
var fyiReport = await create.GenerateRdl(report);
3737
using var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
38-
await fyiReport.RunGetData(null);
38+
await fyiReport.RunGetData();
3939
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.PDF);
4040
var pdfStream = ms.GetStream();
4141

@@ -65,7 +65,7 @@ public async Task PdfDiskExport()
6565
var report = GenerateTestData();
6666
var fyiReport = await create.GenerateRdl(report);
6767
using var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
68-
await fyiReport.RunGetData(null);
68+
await fyiReport.RunGetData();
6969
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.PDF);
7070
var pdfStream = ms.GetStream();
7171
pdfStream.Position = 0;
@@ -91,7 +91,7 @@ public async Task HtmlDiskExport()
9191
var report = GenerateTestData();
9292
var fyiReport = await create.GenerateRdl(report);
9393
using var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
94-
await fyiReport.RunGetData(null);
94+
await fyiReport.RunGetData();
9595
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.HTML);
9696
var pdfStream = ms.GetStream();
9797
pdfStream.Position = 0;

‎RdlCreator.Tests/Reports_DataProviderTest.cs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public async Task TestMethodCsv()
4747
"SELECT CategoryID, CategoryName, Description FROM Categories",
4848
pageHeaderText: "DataProviderTest TestMethod1");
4949
var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
50-
await fyiReport.RunGetData(null);
50+
await fyiReport.RunGetData();
5151
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.CSV);
5252
var text = ms.GetText();
5353

@@ -78,7 +78,7 @@ public async Task TestMethodExcelLegacy()
7878

7979
string filepath = System.IO.Path.Combine(Environment.CurrentDirectory, "TestMethodExcelLegacy.xls");
8080
var ofs = new Majorsilence.Reporting.Rdl.OneFileStreamGen(filepath, true);
81-
await fyiReport.RunGetData(null);
81+
await fyiReport.RunGetData();
8282
await fyiReport.RunRender(ofs, Majorsilence.Reporting.Rdl.OutputPresentationType.ExcelTableOnly);
8383

8484
Assert.Multiple(() =>
@@ -100,7 +100,7 @@ public async Task TestMethodExcel2007()
100100

101101
string filepath = System.IO.Path.Combine(Environment.CurrentDirectory, "TestMethodExcel.xlsx");
102102
var ofs = new Majorsilence.Reporting.Rdl.OneFileStreamGen(filepath, true);
103-
await fyiReport.RunGetData(null);
103+
await fyiReport.RunGetData();
104104
await fyiReport.RunRender(ofs, Majorsilence.Reporting.Rdl.OutputPresentationType.Excel2007);
105105

106106
Assert.That(System.IO.File.Exists(filepath), Is.True);
@@ -118,7 +118,7 @@ public async Task TestMethodExcel2007DataOnly()
118118

119119
string filepath = System.IO.Path.Combine(Environment.CurrentDirectory, "TestMethodExcelDataOnly.xlsx");
120120
var ofs = new Majorsilence.Reporting.Rdl.OneFileStreamGen(filepath, true);
121-
await fyiReport.RunGetData(null);
121+
await fyiReport.RunGetData();
122122
await fyiReport.RunRender(ofs, Majorsilence.Reporting.Rdl.OutputPresentationType.Excel2007DataOnly);
123123

124124
Assert.That(System.IO.File.Exists(filepath), Is.True);
@@ -136,7 +136,7 @@ public async Task TestMethodPdf()
136136

137137
string filepath = System.IO.Path.Combine(Environment.CurrentDirectory, "TestMethodPdf.pdf");
138138
var ofs = new Majorsilence.Reporting.Rdl.OneFileStreamGen(filepath, true);
139-
await fyiReport.RunGetData(null);
139+
await fyiReport.RunGetData();
140140
await fyiReport.RunRender(ofs, Majorsilence.Reporting.Rdl.OutputPresentationType.PDF);
141141

142142
Assert.Multiple(() =>
@@ -166,7 +166,7 @@ public async Task TestReportFromDataTable()
166166
var fyiReport = await create.GenerateRdl(dt,
167167
pageHeaderText: "DataProviderTest TestMethod1");
168168
var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
169-
await fyiReport.RunGetData(null);
169+
await fyiReport.RunGetData();
170170
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.CSV);
171171
var text = ms.GetText();
172172

@@ -211,7 +211,7 @@ public async Task TestReportFromEnumerable()
211211
var fyiReport = await create.GenerateRdl(data,
212212
pageHeaderText: "DataProviderTest TestMethod1");
213213
var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
214-
await fyiReport.RunGetData(null);
214+
await fyiReport.RunGetData();
215215
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.CSV);
216216
var text = ms.GetText();
217217

‎RdlCreator.Tests/Reports_JsonDataProviderTest.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public async Task TestConnectionStrings(string connectionString)
6767
"columns=EmployeID,LastName,FirstName,Title",
6868
pageHeaderText: "DataProviderTest TestMethod1");
6969
var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
70-
await fyiReport.RunGetData(null);
70+
await fyiReport.RunGetData();
7171
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.CSV);
7272
var text = ms.GetText();
7373

@@ -97,7 +97,7 @@ public async Task NestedJson(string connectionString)
9797
"columns=EmployeeID,LastName,FirstName,ContactInfo_Phone,ContactInfo_Email",
9898
pageHeaderText: "DataProviderTest TestMethod1");
9999
var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
100-
await fyiReport.RunGetData(null);
100+
await fyiReport.RunGetData();
101101
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.CSV);
102102
var text = ms.GetText();
103103

‎RdlCreator.Tests/Reports_ManualDefinitionTest.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public async Task CsvExport()
3030
var report = GenerateTestData();
3131
var fyiReport = await create.GenerateRdl(report);
3232
using var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
33-
await fyiReport.RunGetData(null);
33+
await fyiReport.RunGetData();
3434
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.CSV);
3535
var text = ms.GetText();
3636

@@ -56,7 +56,7 @@ public async Task HtmlExport()
5656
var report = GenerateTestData();
5757
var fyiReport = await create.GenerateRdl(report);
5858
using var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
59-
await fyiReport.RunGetData(null);
59+
await fyiReport.RunGetData();
6060
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.HTML);
6161
var text = ms.GetText();
6262

@@ -72,7 +72,7 @@ public async Task PdfStreamExport()
7272
var report = GenerateTestData();
7373
var fyiReport = await create.GenerateRdl(report);
7474
using var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
75-
await fyiReport.RunGetData(null);
75+
await fyiReport.RunGetData();
7676
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.PDF);
7777
var pdfStream = ms.GetStream();
7878

@@ -91,7 +91,7 @@ public async Task PdfDiskExport()
9191
var report = GenerateTestData();
9292
var fyiReport = await create.GenerateRdl(report);
9393
using var ms = new Majorsilence.Reporting.Rdl.MemoryStreamGen();
94-
await fyiReport.RunGetData(null);
94+
await fyiReport.RunGetData();
9595
await fyiReport.RunRender(ms, Majorsilence.Reporting.Rdl.OutputPresentationType.PDF);
9696
var pdfStream = ms.GetStream();
9797
pdfStream.Position = 0;

0 commit comments

Comments
 (0)