Change pre-commit lint hook to pre-push hook

[ekr]

Pre-commit hooks can be a bit of a footgun because people may think they are committing but actually aren't and then the repo is left in a state where your work can be lost. What would you think about moving the pre-commit checks to pre-push checks, at least optionally?

[martinthomson]

Not a bad idea. I had this experience myself yesterday. I do prefer a pre-commit hook, but would support moving to pre-push for people who prefer that.

Rather than have it in the Makefile, I'd use the environment so that it becomes a personal preference. If enabled, what I'd probably do is disable the installation of the pre-commit hook and have the pre-push always invoke the pre-commit hook. It's a little more work if the pre-commit is enabled, but the check is usually pretty quick.

[ekr]

How were you thinking of configuring which mode to use, as it seems like the installation is very early?

[martinthomson]

ID_TEMPLATE_PRE_COMMIT=false in the environment. Then you can make the choice yourself.

The installation only happens at the time that make update is invoked, which doesn't happen immediately.

[martinthomson]

I could also see the script checking for the variable, then exiting cleanly.