Conversation
chippison
force-pushed
the
dev-19876
branch
2 times, most recently
from
dfbe103 to
f3695f4
Compare
adding tests
…resets' on the second click.
fixing some bugs found and adding new tests
…cluttering PresetDateRanges.vue
…lready have in Matomo for the lastXdays
…panel before 'Apply' has been clicked when a preset is being clicked.
…le calendar view, to a double calendar view
…ange picker if its coming from Preset date options.
adding tests
…e/period is unchanged
…e parts of the UI when 'Apply' has not been clicked
…ntext has changed. also adding tests so that its clear that preset options block calendar interactions and period options allow them
…ard coded url params
10 tasks
…nd does not apply pending presets
….component.spec.ts. This test was changing some screenshot tests because it moved the selection
Contributor
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
Member
|
closing, as this was implemented with #24139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DEV-19876
This will add some preset date options to our current calendar.
The new presets are as follows:
Note: Week starts on Monday at Matomo. More details about the presets in DEV-19876
Acceptance Criteria:
A preset list of dates is added to the Calendar
Each date selected highlights the calendar (same behaviour as current period selectors)
User does not need to click in the date picker/calendar, just click “Apply” to apply selected option
“Last week (Mon - Sun)” and “This week (Mon - Today)” have mention to the days included to make it clear which range will be selected
Each preset is implemented according to the table in DEV-19876
Comparison mode works with these new presets
Checklist
Review