Conversation
adding tests
…resets' on the second click.
fixing some bugs found and adding new tests
…cluttering PresetDateRanges.vue
…lready have in Matomo for the lastXdays
…panel before 'Apply' has been clicked when a preset is being clicked.
…le calendar view, to a double calendar view
…ange picker if its coming from Preset date options.
adding tests
…e/period is unchanged
…e parts of the UI when 'Apply' has not been clicked
…ntext has changed. also adding tests so that its clear that preset options block calendar interactions and period options allow them
…ard coded url params
…nd does not apply pending presets
….component.spec.ts. This test was changing some screenshot tests because it moved the selection
…ar-refresh-v2 # Conflicts: # plugins/CoreHome/vue/dist/CoreHome.umd.js # plugins/CoreHome/vue/dist/CoreHome.umd.min.js
…really needed tests, also making sure it does not use `require` and adding some helper functions to tests; updating screenshots as well
chippison
force-pushed
the
calendar-refresh-v2
branch
from
a0ae674 to
7ff444c
Compare
chippison
force-pushed
the
calendar-refresh-v2
branch
2 times, most recently
from
ca33461 to
06bde58
Compare
chippison
force-pushed
the
calendar-refresh-v2
branch
from
06bde58 to
1e983fe
Compare
# Conflicts: # plugins/CoreHome/vue/dist/CoreHome.umd.min.js
chippison
force-pushed
the
calendar-refresh-v2
branch
from
b512ae7 to
8cd5bea
Compare
chippison
force-pushed
the
calendar-refresh-v2
branch
from
d3b4d55 to
ed429bd
Compare
chippison
force-pushed
the
calendar-refresh-v2
branch
from
ed429bd to
b043cf5
Compare
Contributor
Author
|
Will close this down in favour of: #24232 as this has 'cleaner' commit history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DEV-19886
This is for the second half of the calendar refresh.
Not a lot of functional changes from the first one.
This is more of another round of component refactor, and some UI/CSS changes
Checklist
Review