Skip to content

Add robust fallback for goal conversion totals in CalculateConversionPageRate#24222

Closed
sgiehl wants to merge 2 commits into5.x-devfrom
split/goals-conversion-rate-fallback
Closed

Add robust fallback for goal conversion totals in CalculateConversionPageRate#24222
sgiehl wants to merge 2 commits into5.x-devfrom
split/goals-conversion-rate-fallback

Conversation

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 13, 2026

Description

CalculateConversionPageRate depends on top-level goal totals from archive numerics.
In some contexts these totals can be missing/zero, causing page conversion rates to be skipped or incorrect.

If archive totals are unavailable, using reliable totals present in the table allows rate calculation to proceed safely.

refs #24191

Checklist

  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

Review

@sgiehl sgiehl modified the milestone: 5.9.0 Mar 13, 2026
@sgiehl sgiehl force-pushed the split/goals-conversion-rate-fallback branch from 935219c to 7b025f4 Compare March 13, 2026 17:12
@sgiehl
Copy link
Member Author

sgiehl commented Mar 18, 2026

Closing for now. While the solution somewhat works, it just feels incorrect. The problem is somewhere else and shouldn't be fixed that way.

@sgiehl sgiehl closed this Mar 18, 2026
@sgiehl sgiehl removed this from the 5.9.0 milestone Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant