Add robust fallback for goal conversion totals in CalculateConversionPageRate#24222
Closed
Add robust fallback for goal conversion totals in CalculateConversionPageRate#24222
CalculateConversionPageRate#24222Conversation
935219c to
7b025f4
Compare
Member
Author
|
Closing for now. While the solution somewhat works, it just feels incorrect. The problem is somewhere else and shouldn't be fixed that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CalculateConversionPageRatedepends on top-level goal totals from archive numerics.In some contexts these totals can be missing/zero, causing page conversion rates to be skipped or incorrect.
If archive totals are unavailable, using reliable totals present in the table allows rate calculation to proceed safely.
refs #24191
Checklist
Review