Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

Installing mattermost-redux for a global package fails #772

Description

@marklagendijk

Summary

Installation of mattermost-redux fails due to git dependency.

Steps to reproduce

  • sudo npm i -g mattermost-redux

Expected behavior

The module should install without error.
The issue occurs if you want to install a package (for example an cli) which uses mattermost-redux globally.

Observed behavior

npm ERR! code 128
npm ERR! Command failed: /usr/bin/git clone --depth=1 -q -b master https://github.com/enahum/redux-offline.git /root/.npm/_cacache/tmp/git-clone-f7f32218
npm ERR! fatal: could not create leading directories of '/root/.npm/_cacache/tmp/git-clone-f7f32218': Permission denied
npm ERR! 

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-02-12T14_40_06_244Z-debug.log

Possible fixes

  • Remove the redux-offline dependency as git based dependency. If you must use your own version of this package, at least publish it to npm.
  • Split mattermost-redux into different packages. The idea with npm is that packages are small. This package now contains both the client and usages of the client. I propose to at least create mattermost-http-client and mattermost-ws-client as packages. Note: you can still keep the code in one repo.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions