Fix incorrect use of :: vs ++ in editListNested (version 3.0.1)

[decioferreira]

We found that in editListNested, the code currently uses :: where ++ is required (this was found as part of the investigation for guida-lang/compiler#111):

diff --git a/src/Mark/Edit.elm b/src/Mark/Edit.elm
index 0df7c1f..1b6f9fb 100644
--- a/src/Mark/Edit.elm
+++ b/src/Mark/Edit.elm
@@ -815,7 +815,7 @@ editListNested cursor lsNested =
 
                             EditMade maybeSeed maybePush newChild ->
                                 ( EditMade maybeSeed maybePush []
-                                , newChild :: pastChildren
+                                , newChild ++ pastChildren
                                 )
             )
             ( NoIdFound, [] )

This compiles in Elm either way, but only the ++ version seems correct.
The Guida compiler seems to correctly enforce this, and only accepts the ++ version.

Suggestion: Apply this diff and publish a new patch release, so that it could be used on Guida projects.

I suspect this may also cause subtle issues when running on Elm, but I haven’t been able to verify it yet.

[rupertlssmith]

I added a type annotation to try and pin down the type of the expressions, so now I have:

lsNested
        |> List.foldl
            (\foundChild ( editMade, pastChildren ) ->
            let
                res : ( EditOutcome (List a), List (Nested Description) )
                res = case editMade of
                    EditMade maybeSeed maybePush _ ->
                        ( editMade
                        , pushNested maybePush foundChild :: pastChildren
                        )

                    ErrorMakingEdit err ->
                        ( ErrorMakingEdit err
                        , foundChild :: pastChildren
                        )

                    NoIdFound ->
                        case editNested indentedCursor foundChild of
                            NoIdFound ->
                                ( NoIdFound
                                , foundChild :: pastChildren
                                )

                            ErrorMakingEdit err ->
                                ( ErrorMakingEdit err
                                , foundChild :: pastChildren
                                )

                            EditMade maybeSeed maybePush newChild ->
                                ( EditMade maybeSeed maybePush []
                                , newChild :: pastChildren
                                )
            in
            res
            )
            ( NoIdFound, [] )

and the elm compiler gave me:

Compiling ...elm: You ran into a compiler bug. Here are some details for the developers:

    a [rank = 2]

Please create an <http://sscce.org/> and then report it
at <https://github.com/elm/compiler/issues>


CallStack (from HasCallStack):
  error, called at compiler/src/Type/Solve.hs:206:15 in main:Type.Solve

-- ERROR -----------------------------------------------------------------------

I ran into something that bypassed the normal error reporting process! I
extracted whatever information I could from the internal error:

>   thread blocked indefinitely in an MVar operation

These errors are usually pretty confusing, so start by asking around on one of
forums listed at https://elm-lang.org/community to see if anyone can get you
unstuck quickly.

This would seem the be the same bug as already reported against the compiler: http://github.com/elm/compiler/issues/2296

And that issue already has an SSCCE for it.