Remove quick edit #4866
|
I did a quick unscientific poll on Slack, and it seems that basically nobody uses this feature. If you want this feature to stay add a 👎 and if you do not use it and would not mind if it is removed, vote it up - Thanks! |
Replies: 3 comments 4 replies
|
Note that the "Quick-edit" could be changed to "Edit on github" to cover most use cases. (Edit on github is already at the bottom of the page, but this would make it more visible) The only use case I have that wouldn't be covered is when fixing a bunch of flaws in a row, on different pages, and not willing to create a PR per page. But that's such a narrow use case, that I think we should get rid of the feature. |
|
I have no idea what "quick edit" is, so I won't be harmed by its removal, but it might help to explain what you're talking about here, @schalkneethling. |
|
Quick-edit is an edition mode triggered by pressing the Quick-edit button on a page displayed locally (localhost:5000). It leads to a crude editor, without syntax highlighting, without the ability to edit the YAML headers. The page is then saved locally. It has problems (if you go back and don't reload the page, you override your latest changes).
It is only useful when you do a batch of trivial changes locally, and you don't want/can configure an external editor. If you do more complex changes, you use an external editor; if you do a single trivial change, you use the Edit on GitHub link at the bottom of the page. Workaround for the batch of trivial changes use case: configure your editor properly in yari and click the left-most button Open in your editor. |
|
Ahh, interesting! Thank you, @teoli2003. Yeah, I agree that we don't need to maintain this tool, especially since the move to Markdown. |
|
Sounds like we have reached a consensus so, unless someone responds with a convincing reason against it, I will open an issue this week to remove the functionality and replace it with the same "Edit on GitHub" link as @teoli2003 suggested. |
Sounds like we have reached a consensus so, unless someone responds with a convincing reason against it, I will open an issue this week to remove the functionality and replace it with the same "Edit on GitHub" link as @teoli2003 suggested.