def_input_pad macro generated incorrect code

[manhvu]

I got some errors from plugins when try to use Membrane frame.

I think def_input_pad macro has an issue with alias.

membrane_acc_fdk_plugin issue:

[error] GenServer #PID<0.1315.0> terminating
** (Membrane.StreamFormatError) Stream format: %Membrane.AAC{sample_rate: 48000, channels: 1, profile: :LC, mpeg_version: 4, samples_per_frame: 1024, frames_per_buffer: 1, encapsulation: :ADTS, config: nil} is not matching accepted format pattern `%AAC{config: {:esds, _esds}}`, `%Opus{self_delimiting?: false}`, `%H264{stream_structure: structure, alignment: :au} when H264.is_avc(structure)` or `%H265{stream_structure: structure, alignment: :au} when H265.is_hvc(structure)` in def_input_pad for pad :input in Membrane.MP4.Muxer.CMAF. Beware that stream format is forwarded by the default implemetation of handle_stream_format in filters.

membrane_transcoder_plugin issue:

[error] <0.21118.0>/:cam1/:transcoder/:output_funnel Error occured in Membrane Element:
** (Membrane.StreamFormatError) Stream format: %Membrane.RawVideo{width: 1920, height: 1080, framerate: nil, pixel_format: :I420, aligned: true} is not matching accepted format pattern `%RawVideo{width: 1920, height: 1080, framerate: 30, pixel_format: :I420, aligned: true}` in def_output_pad for pad :video in HumanDetector.Pipes.Bin.InputRtmp. Beware that stream format is forwarded by the default implemetation of handle_stream_format in filters.

Macro not generated full module name for H264 & RawVideo

(I tested issue on both Elixir 1.19.5 & Elixir 1.18.4).

[varsill]

Hello! These issues are due to a mismatch in stream format struct's content i.e.:

• for the membrane_aac_fdk_plugin issue, the incoming stream format %Membrane.AAC{} needs to have config: {:esds, _esds} and the stream format received on the input pad has config: nil
• for the membrane_transcoder_plugin issue the stream format sent on the output pad needs to have framerate: 30 (as specified by this HumanDetector.Pipes.Bin. InputRtmp bin) and the sent stream format has framerate: nil.

The aliases for the stream format patterns are indeed not fully resolved in the error message, but it's not causing the error itself (it might indeed be slightly confusing though :D)

[manhvu]

Hi, I fixed the issues, but I mean def_input_pad macro does not generate full struct name (I fixed by add full struct name) from alias in code. I will back to this later & see what happens

[varsill]

Yeah, we know that the module name from the macro in the error message doesn't take into account aliases, but there is little we can do about it 😥
However the assertion mechanism should work correctly (as it definitely takes into consideration aliases).