Skip to content

Commit 0d8ea79

Browse files
committed
Update return values in callbacks to reflect 1.0 spec
1 parent ad0977d commit 0d8ea79

File tree

2 files changed

+79
-79
lines changed

2 files changed

+79
-79
lines changed

basic_pipeline/07_Redemands.md

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -10,49 +10,49 @@ To comprehensively understand the concept behind redemanding, you need to be awa
1010

1111
## In Source elements
1212

13-
In the [source elements](../glossary/glossary.md#source), there is a "side-channel", from which we can receive data. That "side-channel" can be, as in the exemplary [pipeline](../glossary/glossary.md#pipeline) we are working on, in form of a file, from which we are reading the data. In real-life scenarios it could be also, i.e. an [RTP](../glossary/glossary.md#rtp) stream received via the network. Since we have that "side-channel", there is no need to receive data via the input [pad](../glossary/glossary.md#pad) (that is why we don't have it in the source element, do we?).
14-
The whole logic of fetching the data can be put inside the `handle_demand/5` callback - once we are asked to provide the [buffers](../glossary/glossary.md#buffer), the `handle_demand/5` callback gets called and we can provide the desired number of buffers from the "side-channel", inside the body of that callback. No processing occurs here - we get asked for the buffer and we provide the buffer, simple as that.
15-
The redemand mechanism here lets you focus on providing a single buffer in the `handle_demand/5` body - later on, you can simply return the `:redemand` action and that action will invoke the `handle_demand/5` once again, with the updated number of buffers which are expected to be provided. Let's see it in an example - we could have such a `handle_demand/5` definition (and it wouldn't be a mistake!):
13+
In the [source elements](../glossary/glossary.md#source), there is a "side-channel", from which we can receive data. That "side-channel" can be, as in the example [pipeline](../glossary/glossary.md#pipeline) we are working on, in the form of a file, from which we are reading the data. In real-life scenarios it could also be, i.e. an [RTP](../glossary/glossary.md#rtp) stream received via the network. Since we have that "side-channel", there is no need to receive data via the input [pad](../glossary/glossary.md#pad) (that is why we don't have it in the source element).
14+
The whole logic of fetching the data can be put inside the `handle_demand/5` callback - once we are asked to provide the [buffers](../glossary/glossary.md#buffer), the `handle_demand/5` callback gets called and we can provide the desired number of buffers from the "side-channel" inside the body of that callback. No processing occurs here - we get asked for the buffer and we provide the buffer, simple as that.
15+
The redemand mechanism here lets you focus on providing a single buffer in the `handle_demand/5` body - later on, you can simply return the `:redemand` action and that action will invoke `handle_demand/5` once again, with the updated number of buffers which are expected to be provided. Let's see it in an example - we could have such a `handle_demand/5` definition (and it wouldn't be a mistake!):
1616

1717
```elixir
1818
@impl true
1919
def handle_demand(:output, size, _unit, _context, state) do
20-
actions = for x <- 1..size do
21-
payload = Input.get_next() #Input.get_next() is an exemplary function which could be providing data
22-
{:buffer, %Membrane.Buffer(payload: payload)}
23-
end
24-
{ {:ok, actions}, state}
20+
actions = for x <- 1..size do
21+
payload = Input.get_next() #Input.get_next() is an example function providing data
22+
{:buffer, %Membrane.Buffer{payload: payload}}
23+
end
24+
{actions, state}
2525
end
2626
```
2727

28-
As you can see in the snippet above, we need to generate the required `size` of buffers in the single `handle_demand/5` run. The logic of supplying the demand there is quite easy - but what if you would also need to check if there is enough data to provide a sufficient number of buffer? You would need to check it in advance (or try to read as much data as possible before supplying the desired number of buffers). And what if an exception occurs during the generation, before supplying all the buffers?
29-
You would need to take under the consideration all these situations and your code would become larger and larger.
28+
As you can see in the snippet above, we need to generate the required `size` of buffers in the single `handle_demand/5` run. The logic of supplying the demand there is quite easy - but what if you would also need to check if there is enough data to provide a sufficient number of buffers? You would need to check it in advance (or try to read as much data as possible before supplying the desired number of buffers). And what if an exception occurs during the generation, before supplying all the buffers?
29+
You would need to consider all these situations and your code would become larger and larger.
3030

3131
Wouldn't it be better to focus on a single buffer in each `handle_demand/5` call - and let the Membrane Framework automatically update the demand's size? This can be done in the following way:
3232

3333
```elixir
3434
@impl true
3535
def handle_demand(:output, _size, unit, context, state) do
36-
payload = Input.get_next() #Input.get_next() is an exemplary function which could be providing data
37-
actions = [buffer: %Membrane.Buffer(payload: payload), redemand: :output]
38-
{ {:ok, actions}, state}
36+
payload = Input.get_next()
37+
actions = [buffer: %Membrane.Buffer(payload: payload), redemand: :output]
38+
{actions, state}
3939
end
4040
```
4141

4242
## In Filter elements
43-
In the filter element, the situation is quite different.
43+
In a filter element, the situation is quite different.
4444
Since the filter's responsibility is to process the data sent via the input pads and transmit it through the output pads, there is no 'side-channel' from which we could take data. That is why in normal circumstances you would transmit the buffer through the output pad in the `handle_buffer/4` callback (which means - once your element receives a buffer, you process it, and then you 'mark' it as ready to be output with the `:buffer` action). When it comes to the `handle_demand/5` action on the output pad, all you need to do is to demand the appropriate number of buffers on the element's input pad.
4545

46-
That behavior is easy to specify when we exactly know how many input buffers correspond to the one output buffer (recall the situation in the [Depayloader](../glossary/glossary.md#payloader-and-depayloader) of our pipeline, where we *a priori* knew, that each output buffer ([frame](../glossary/glossary.md#frame)) consists of a given number of input buffers ([packets](../glossary/glossary.md#packet))). However it becomes impossible to define if the output buffer might be a combination of a discretionary set number of input buffers. At the same time, we have dealt with an unknown number of required buffers in the OrderingBuffer implementation, where we didn't know how many input buffers do we need to demand to fulfill the missing spaces between the packets ordered in the list. How did we manage to do it?
46+
That behavior is easy to specify when we know exactly how many input buffers correspond to one output buffer (recall the situation in the [Depayloader](../glossary/glossary.md#payloader-and-depayloader) of our pipeline, where we *a priori* knew, that each output buffer ([frame](../glossary/glossary.md#frame)) consists of a given number of input buffers ([packets](../glossary/glossary.md#packet))). However it becomes impossible to define if the output buffer might be a combination of a discretionary set number of input buffers. At the same time, we have dealt with an unknown number of required buffers in the OrderingBuffer implementation, where we didn't know how many input buffers we would need to demand to fulfill the missing spaces between the packets ordered in the list. How did we manage to do it?
4747

48-
We simply used the `:redemand` action! In case there was a missing space between the packets, we returned the `:redemand` action, which immediately called the `handle_demand/5` callback (implemented in a way to request for a buffer on the input pad). The fact, that that callback invocation was immediate, which means - the callback was called synchronously, right after returning from the `handle_buffer/4` callback, before processing any other message from the element's mailbox - might be crucial in some situations, since it guarantees that the demand will be done before handling any other event.
48+
We simply used the `:redemand` action! In case there was a missing space between the packets, we returned the `:redemand` action, which immediately called the `handle_demand/5` callback (implemented in a way to request for a buffer on the input pad). The fact that that callback invocation was immediate (the callback was called synchronously, right after returning from the `handle_buffer/4` callback, before processing any other message from the element's mailbox) might be crucial in some situations, since it guarantees that the demand will be done before handling any other event.
4949
Recall the situation in the [Mixer](../glossary/glossary.md#mixer), where we were producing the output buffers right in the `handle_demand/5` callback. We needed to attempt to create the output buffer after:
5050

5151
- updating the buffers' list in `handle_buffer/4`
5252
- updating the status of the [track](../glossary/glossary.md#track) in `handle_end_of_stream/3`
53-
Therefore, we were simply returning the `:redemand` action, and the `handle_demand/5` was called sequentially after on, trying to produce the output buffer.
53+
Therefore, we were simply returning the `:redemand` action, and the `handle_demand/5` was called sequentially afterwards, trying to produce the output buffer.
5454

55-
As you can see, redemand mechanism in filters helps us deal with situations, where we do not know how many input buffers to demand in order to be able to produce an output buffer/buffers.
56-
In case we don't provide enough buffers in the `handle_demand/5` callback (or we are not sure that we do provide), we should call `:redemand` somewhere else (usually in the `handle_buffer/4`) to make sure that the demand is not lost.
55+
As you can see, redemand mechanism in filters helps us deal with situations where we do not know how many input buffers to demand in order to be able to produce an output buffer/buffers.
56+
In case we don't provide enough buffers in the `handle_demand/5` callback (or we are not sure that we do), we should call `:redemand` somewhere else (usually in the `handle_buffer/4`) to make sure that the demand is not lost.
5757

5858
With that knowledge let's carry on with the next element in our pipeline - `Depayloader`.

broadcasting/05_RTMP_Pipeline.md

Lines changed: 60 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -8,28 +8,28 @@ which is invoked once the pipeline is initialized.
88
**_`lib/rtmp_to_hls/pipeline.ex`_**
99

1010
```elixir
11-
@impl true
12-
def handle_init(_opts) do
13-
...
14-
children: %{
15-
src: %Membrane.RTMP.SourceBin{port: 9009},
16-
sink: %Membrane.HTTPAdaptiveStream.SinkBin{
17-
manifest_module: Membrane.HTTPAdaptiveStream.HLS,
18-
target_window_duration: 20 |> Membrane.Time.seconds(),
19-
muxer_segment_duration: 8 |> Membrane.Time.seconds(),
20-
storage: %Membrane.HTTPAdaptiveStream.Storages.FileStorage{directory: "output"}
21-
}
22-
},
23-
...
24-
end
11+
@impl true
12+
def handle_init(_opts) do
13+
...
14+
children: %{
15+
src: %Membrane.RTMP.SourceBin{port: 9009},
16+
sink: %Membrane.HTTPAdaptiveStream.SinkBin{
17+
manifest_module: Membrane.HTTPAdaptiveStream.HLS,
18+
target_window_duration: 20 |> Membrane.Time.seconds(),
19+
muxer_segment_duration: 8 |> Membrane.Time.seconds(),
20+
storage: %Membrane.HTTPAdaptiveStream.Storages.FileStorage{directory: "output"}
21+
}
22+
},
23+
...
24+
end
2525
```
2626

2727
First, we define the list of children. The following children are defined:
2828

2929
- `:src` - a `Membrane.RTMP.SourceBin`, an RTMP server, which, according to its `:port` configuration, will be listening on port `9009`. This bin will be acting as a source for our pipeline. For more information on RTMP Source Bin please visit [the documentation](https://hexdocs.pm/membrane_rtmp_plugin/Membrane.RTMP.SourceBin.html).
3030
- `:sink` - a `Membrane.HTTPAdaptiveStream.SinkBin`, acting as a sink of the pipeline. The full documentation of that bin is available [here](https://hexdocs.pm/membrane_http_adaptive_stream_plugin/Membrane.HTTPAdaptiveStream.SinkBin.html). We need to specify some of its options:
3131
- `:manifest_module` - a module which implements [`Membrane.HTTPAdaptiveStream.Manifest`](https://hexdocs.pm/membrane_http_adaptive_stream_plugin/Membrane.HTTPAdaptiveStream.Manifest.html#c:serialize/1) behavior. A manifest allows aggregate tracks (of a different type, i.e. an audio track and a video track as well as many tracks of the same type, i.e. a few video tracks with different resolutions). For each track, the manifest holds a reference to a list of segments, which form that track. Furthermore, the manifest module is equipped with the `serialize/1` method, which allows transforming that manifest to a string (which later on can be written to a file). In that case, we use a built-in implementation of a manifest module - the `Membrane.HTTPAdaptiveStream.HLS`, designed to serialize a manifest into a form required by HLS.
32-
- `:target_window_duriation` - that value determines the minimal manifest's duration. The oldest segments of the tracks will be removed whenever possible if persisting them would result in exceeding the manifest duration.
32+
- `:target_window_duriation` - determines the minimal manifest's duration. The oldest segments of the tracks will be removed whenever possible if persisting them would result in exceeding the manifest duration.
3333
- `:muxer_segment_duration` - the maximal duration of a segment. Each segment of each track shouldn't exceed that value. In our case, we have decided to limit the length of each segment to 8 seconds.
3434
- `:storage` - the sink element, the module responsible for writing down the HLS playlist and manifest files. In our case, we use a pre-implemented `Membrane.HTTPAdaptiveStream.FileStorage` module, designed to write the files to the local filesystem. We configure it so that the directory where the files will be put in the `output/` directory (make sure that that directory exists as the storage module won't create it itself).
3535

@@ -39,21 +39,21 @@ After providing the children's specifications, we are ready to connect the pads
3939
**_`lib/rtmp_to_hls/pipeline.ex`_**
4040

4141
```elixir
42-
@impl true
43-
def handle_init(_opts) do
44-
...
45-
links: [
46-
link(:src)
47-
|> via_out(:audio)
48-
|> via_in(Pad.ref(:input, :audio), options: [encoding: :AAC])
49-
|> to(:sink),
50-
link(:src)
51-
|> via_out(:video)
52-
|> via_in(Pad.ref(:input, :video), options: [encoding: :H264])
53-
|> to(:sink)
54-
]
55-
...
56-
end
42+
@impl true
43+
def handle_init(_opts) do
44+
...
45+
links: [
46+
link(:src)
47+
|> via_out(:audio)
48+
|> via_in(Pad.ref(:input, :audio), options: [encoding: :AAC])
49+
|> to(:sink),
50+
link(:src)
51+
|> via_out(:video)
52+
|> via_in(Pad.ref(:input, :video), options: [encoding: :H264])
53+
|> to(:sink)
54+
]
55+
...
56+
end
5757
```
5858

5959
The structure of links reflects the desired architecture of the application.
@@ -67,11 +67,11 @@ The final thing that is done in the `handle_init/1` callback's implementation is
6767
**_`lib/rtmp_to_hls/pipeline.ex`_**
6868

6969
```elixir
70-
@impl true
71-
def handle_init(_opts) do
72-
...
73-
{ {:ok, spec: spec, playback: :playing}, %{} }
74-
end
70+
@impl true
71+
def handle_init(_opts) do
72+
...
73+
{[spec: spec, playback: :playing], %{}}
74+
end
7575
```
7676

7777
The first action is the `:spec` action, which spawns the children. The second action changes the playback state of the pipeline into the `:playing` - meaning, that data can start flowing through the pipeline.
@@ -83,51 +83,51 @@ The pipeline is started with `Supervisor.start_link`, as a child of the applicat
8383
**_`lib/rtmp_to_hls/application.ex`_**
8484

8585
```elixir
86-
@impl true
87-
def start(_type, _args) do
88-
children = [
89-
# Start the Pipeline
90-
Membrane.Demo.RtmpToHls,
91-
...
92-
]
93-
opts = [strategy: :one_for_one, name: RtmpToHls.Supervisor]
94-
Supervisor.start_link(children, opts)
95-
end
86+
@impl true
87+
def start(_type, _args) do
88+
children = [
89+
# Start the Pipeline
90+
Membrane.Demo.RtmpToHls,
91+
...
92+
]
93+
opts = [strategy: :one_for_one, name: RtmpToHls.Supervisor]
94+
Supervisor.start_link(children, opts)
95+
end
9696
```
9797

9898
## HLS controller
9999

100100
The files produced with the pipeline are written down to the `output/` directory. We need to make them accessible via HTTP.
101-
The Phoenix Framework provides tools to achieve that - take a look at the `RtmpToHlsWeb.Router`:
101+
The Phoenix Framework provides tools to achieve that - take a look at `RtmpToHlsWeb.Router`:
102102
**_`lib/rtmp_to_hls_web/router.ex`_**
103103

104104
```elixir
105105
scope "/", RtmpToHlsWeb do
106-
pipe_through :browser
106+
pipe_through :browser
107107

108-
get "/", PageController, :index
109-
get "/video/:filename", HlsController, :index
110-
end
111-
```
108+
get "/", PageController, :index
109+
get "/video/:filename", HlsController, :index
110+
end
111+
```
112112

113113
We are directing HTTP requests on `/video/:filename` to the HlsController, whose implementation is shown below:
114114
**_`lib/rtmp_to_hls_web/controllers/hls_controller.ex`_**
115115

116116
```elixir
117117
defmodule RtmpToHlsWeb.HlsController do
118-
use RtmpToHlsWeb, :controller
118+
use RtmpToHlsWeb, :controller
119119

120-
alias Plug
120+
alias Plug
121121

122-
def index(conn, %{"filename" => filename}) do
123-
path = "output/#{filename}"
122+
def index(conn, %{"filename" => filename}) do
123+
path = "output/#{filename}"
124124

125-
if File.exists?(path) do
126-
conn |> Plug.Conn.send_file(200, path)
127-
else
128-
conn |> Plug.Conn.send_resp(404, "File not found")
129-
end
125+
if File.exists?(path) do
126+
conn |> Plug.Conn.send_file(200, path)
127+
else
128+
conn |> Plug.Conn.send_resp(404, "File not found")
130129
end
130+
end
131131
end
132132
```
133133

0 commit comments

Comments
 (0)