[SM6.10][HLK] Use Template Load/Store for Shaders#8350
Merged
V-FEXrt merged 2 commits intomicrosoft:mainfrom Apr 8, 2026
Merged
[SM6.10][HLK] Use Template Load/Store for Shaders#8350V-FEXrt merged 2 commits intomicrosoft:mainfrom
V-FEXrt merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
You can test this locally with the following command:git-clang-format --diff ec6ba97b757633c2e680d307342716527645930c 0196257b25b36a86242b227cfb13cdfeb9f1022d -- tools/clang/unittests/HLSLExec/LinAlgTests.cppView the diff from clang-format here.diff --git a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
index 6f4c5c54..2e4ce65d 100644
--- a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
+++ b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
@@ -98,15 +98,15 @@ static std::string buildCompilerArgs(const MatrixParams &Params,
SS << " -DELEM_SIZE=" << elementSize(Params.CompType);
SS << " -DNUMTHREADS=" << Params.NumThreads;
switch (Params.CompType) {
- case ComponentType::F16:
- SS << " -DELEM_TYPE=half";
- break;
- case ComponentType::F32:
- SS << " -DELEM_TYPE=float";
- break;
- default:
- SS << " -DELEM_TYPE=uint";
- break;
+ case ComponentType::F16:
+ SS << " -DELEM_TYPE=half";
+ break;
+ case ComponentType::F32:
+ SS << " -DELEM_TYPE=float";
+ break;
+ default:
+ SS << " -DELEM_TYPE=uint";
+ break;
}
if (Params.EmulateTest)
SS << " -DEMULATE_TEST";
|
jenatali
approved these changes
Apr 7, 2026
Member
jenatali
left a comment
There was a problem hiding this comment.
Review for the actual commit that this PR is for, that's much cleaner.
tex3d
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on top of #8343, will move out of draft after that merges
Internal feedback was provided to use the templated Load/Store methods. This PR makes that change, and then simplifies the shaders/built in defines in response to those changes.