Skip to content

[SM6.10][HLK] Use Template Load/Store for Shaders#8350

Merged
V-FEXrt merged 2 commits intomicrosoft:mainfrom
V-FEXrt:lhi4
Apr 8, 2026
Merged

[SM6.10][HLK] Use Template Load/Store for Shaders#8350
V-FEXrt merged 2 commits intomicrosoft:mainfrom
V-FEXrt:lhi4

Conversation

@V-FEXrt
Copy link
Copy Markdown
Collaborator

@V-FEXrt V-FEXrt commented Apr 7, 2026

Build on top of #8343, will move out of draft after that merges

Internal feedback was provided to use the templated Load/Store methods. This PR makes that change, and then simplifies the shaders/built in defines in response to those changes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff ec6ba97b757633c2e680d307342716527645930c 0196257b25b36a86242b227cfb13cdfeb9f1022d -- tools/clang/unittests/HLSLExec/LinAlgTests.cpp
View the diff from clang-format here.
diff --git a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
index 6f4c5c54..2e4ce65d 100644
--- a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
+++ b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
@@ -98,15 +98,15 @@ static std::string buildCompilerArgs(const MatrixParams &Params,
   SS << " -DELEM_SIZE=" << elementSize(Params.CompType);
   SS << " -DNUMTHREADS=" << Params.NumThreads;
   switch (Params.CompType) {
-    case ComponentType::F16:
-      SS << " -DELEM_TYPE=half";
-      break;
-    case ComponentType::F32:
-      SS << " -DELEM_TYPE=float";
-      break;
-    default:
-      SS << " -DELEM_TYPE=uint";
-      break;
+  case ComponentType::F16:
+    SS << " -DELEM_TYPE=half";
+    break;
+  case ComponentType::F32:
+    SS << " -DELEM_TYPE=float";
+    break;
+  default:
+    SS << " -DELEM_TYPE=uint";
+    break;
   }
   if (Params.EmulateTest)
     SS << " -DEMULATE_TEST";
  • Check this box to apply formatting changes to this branch.

Copy link
Copy Markdown
Member

@jenatali jenatali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for the actual commit that this PR is for, that's much cleaner.

@V-FEXrt V-FEXrt marked this pull request as ready for review April 8, 2026 19:41
@V-FEXrt V-FEXrt merged commit 56dcdbc into microsoft:main Apr 8, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 8, 2026
@V-FEXrt V-FEXrt deleted the lhi4 branch April 8, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants