Add X25519 generateKey overload to SubtleCrypto #2358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a specific overload for the X25519 key exchange algorithm to the
SubtleCrypto.generateKey()method, following the same pattern as the existing Ed25519 overload.Changes
Added the following overload to
SubtleCryptointerface ininputfiles/overridingTypes.jsonc:Rationale
X25519 is used for key derivation (ECDH), so it uses
deriveBitsandderiveKeyas valid keyUsages, unlike Ed25519 which usessignandverify.This allows TypeScript to correctly infer
CryptoKeyPairas the return type when using X25519, eliminating the need for type assertions or instanceof checks:Browser Support
X25519 is supported by:
This meets the requirement of support by 2+ major browser engines.
References