Skip to content

Commit 21feb28

Browse files
committed
apply review comment
1 parent ae873d4 commit 21feb28

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/compiler/checker.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27295,7 +27295,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
2729527295

2729627296
let isDiscriminant = transientSymbol.links.isDiscriminantProperty.get(considerNonUniformPrimitivePropDiscriminant);
2729727297

27298-
if (typeof isDiscriminant === "undefined") {
27298+
if (isDiscriminant === undefined) {
2729927299
isDiscriminant = (((transientSymbol.links.checkFlags & CheckFlags.Discriminant) === CheckFlags.Discriminant)
2730027300
|| !!(considerNonUniformPrimitivePropDiscriminant && (transientSymbol.links.checkFlags & CheckFlags.HasNonUniformType) && someType(propType, t => !!(t.flags & TypeFlags.Primitive))))
2730127301
&& !isGenericType(propType);
@@ -27312,7 +27312,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
2731227312
function findDiscriminantProperties(sourceProperties: Symbol[], target: Type): Symbol[] | undefined {
2731327313
let result: Symbol[] | undefined;
2731427314
for (const sourceProperty of sourceProperties) {
27315-
if (isDiscriminantProperty(target, sourceProperty.escapedName, /*considerNonUniformPrimitivePropDiscriminant*/ false)) {
27315+
if (isDiscriminantProperty(target, sourceProperty.escapedName, /*considerNonUniformPrimitivePropDiscriminant*/ true)) {
2731627316
if (result) {
2731727317
result.push(sourceProperty);
2731827318
continue;

0 commit comments

Comments
 (0)