Deep refresh error: Failed to deep refresh: An item with the provided index does not exist

[evgenyvalavin]

Describe the bug

Trying to refresh an object which already doesn't exist in DB results in an error.

To Reproduce

Steps to reproduce the behavior:

1. Expand to a table in a db.
2. Drop the table.
3. Click the refresh icon on the table
4. See the table has not disappeared and VS shows an error: "[9:37:09 PM] [ObjectExplorerService] [Error]: Deep refresh error: Failed to deep refresh: An item with the provided index does not exist"

Expected behavior

Try to refresh each root until a root that exists is found or go up to refreshing the whole connection.

BTW. The behavior seems to be different for columns and tables. If I click refresh on a column that is already deleted, I see no issue and the column disappears (see "getting children for node" on the screenshot). I go upwards and try to refresh the table which contained the column and get the error.

Screenshots

Click refresh on a table:

VS Code version

1.116.0

Extension Logs

Version: 1.20.0

[mmcfarland]

Thanks @evgenyvalavin -- will check this out and get a fix rolling.

[mmcfarland]

Hi @evgenyvalavin, this has been fixed in v1.21.1 (pre-release). Refreshing an Object Explorer node whose underlying object no longer exists should now walk up to the nearest valid ancestor and refresh from there, instead of surfacing the "An item with the provided index does not exist" error. Could you give it a try with your drop-then-refresh repro and let us know if it behaves as you'd expect?