Skip to content

Document lack of versioning in request method. #323

Description

@martey

@dursk raised a great and prescient point in an message on the Google Group several months ago:

Either request() should be marked private as _request(), or, since the API calls funnel through request(), the versioning should be handled within this method rather than passed to this method by all callers.

Since then, multiple people have suggested the latter solution (see #284 and #302). As I mentioned in those issues, I think the latter solution will end up causing additional issues. I think the former solution (suggesting that the request method is private and should not be used unless you know what you are doing) is better.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions