Tests are not correctly feature-gated

[tyilo]

Running cargo test on the main branch (478e46b) results in the following test failures:

$ cargo test
...
failures:
    src/binary/vector.rs - binary::vector::Vector (line 24)
    src/datetime.rs - datetime::DateTime (line 56)
    src/datetime.rs - datetime::DateTime (line 83)
    src/lib.rs - (line 183)
    src/lib.rs - (line 234)
    src/lib.rs - (line 263)
    src/lib.rs - (line 318)
    src/lib.rs - (line 340)
    src/lib.rs - (line 361)
    src/oid.rs - oid::ObjectId (line 41)
    src/oid.rs - oid::ObjectId (line 72)
    src/raw/array.rs - raw::array::RawArray (line 34)

test result: FAILED. 65 passed; 12 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.93s

error: doctest failed, to rerun pass `--doc`

Running cargo test --all-features succeeds:

$ cargo test --all-features
...
test result: ok. 104 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 12.44s

This must mean that the tests are not properly feature-gated.

[isabelatkinson]

Hey @tyilo, this is a known issue for us:

bson-rust/.evergreen/run-tests.sh

Line 7 in 478e46b

# Test with default features and excluding doctests (some of which require the 'serde' feature)

I believe the team generally uses cargo-nextest locally, which does not run docs tests by default. I suggest doing the same or skipping the docs tests if you're not testing with all features enabled.

[github-actions]

There has not been any recent activity on this ticket, so we are marking it as stale. If we do not hear anything further from you, this issue will be automatically closed in one week.

[tyilo]

Fair enough, still doesn't seem a like big change to feature-gate the 12 failing doctests:

failures:
    src/binary/vector.rs - binary::vector::Vector (line 24)
    src/datetime.rs - datetime::DateTime (line 56)
    src/datetime.rs - datetime::DateTime (line 83)
    src/lib.rs - (line 183)
    src/lib.rs - (line 234)
    src/lib.rs - (line 263)
    src/lib.rs - (line 318)
    src/lib.rs - (line 340)
    src/lib.rs - (line 361)
    src/oid.rs - oid::ObjectId (line 41)
    src/oid.rs - oid::ObjectId (line 72)
    src/raw/array.rs - raw::array::RawArray (line 34)

[isabelatkinson]

This isn't a priority for the team, but feel free to put up a PR and we can review it