fix: resolve MoonBit check warnings

Author: Yoorkin

rui/context_menu.mbt

@@ -454,10 +454,8 @@ fn context_scope(
   point_x : Int,
   point_y : Int,
   set_open : @cmd.Emit[Bool],
-  set_active : @cmd.Emit[Int],
   toggle_checked : @cmd.Emit[String],
   set_radio : @cmd.Emit[(String, String)],
-  set_submenu : @cmd.Emit[MenuSubmenuChange],
 ) -> ContextMenuScope {
   {
     point_x,
@@ -468,13 +466,10 @@ fn context_scope(
       trigger_id: id + "-trigger",
       model,
       counter: Ref(0),
-      open_command: set_open(true),
       close_command: set_open(false),
       toggle_command: set_open(!model.open),
-      set_active,
       toggle_checked,
       set_radio,
-      set_submenu,
     },
   }
 }
@@ -656,10 +651,8 @@ pub fn context_menu(
       model.point_x,
       model.point_y,
       emit.map(open => ContextSetOpen(open)),
-      emit.map(index => ContextSetActive(index)),
       emit.map(value => ContextToggleChecked(value)),
       emit.map(pair => ContextSetRadio(pair.0, pair.1)),
-      emit.map(value => ContextSetSubmenu(value)),
     )
     menu_root_surface(
       "context-menu",
@@ -693,8 +686,6 @@ pub fn context_menu(
     menu_noop_emit(),
     menu_noop_emit(),
     menu_noop_emit(),
-    menu_noop_emit(),
-    menu_noop_emit(),
   )
   @rabbita.Val::constant(
     menu_root_surface(

rui/dropdown_menu.mbt

@@ -41,10 +41,8 @@ fn dropdown_scope(
   id : String,
   model : MenuCoreModel,
   set_open : @cmd.Emit[Bool],
-  set_active : @cmd.Emit[Int],
   toggle_checked : @cmd.Emit[String],
   set_radio : @cmd.Emit[(String, String)],
-  set_submenu : @cmd.Emit[MenuSubmenuChange],
 ) -> DropdownMenuScope {
   {
     menu: {
@@ -53,13 +51,10 @@ fn dropdown_scope(
       trigger_id: id + "-trigger",
       model,
       counter: Ref(0),
-      open_command: set_open(true),
       close_command: set_open(false),
       toggle_command: set_open(!model.open),
-      set_active,
       toggle_checked,
       set_radio,
-      set_submenu,
     },
   }
 }
@@ -200,10 +195,8 @@ pub fn dropdown_menu(
       id,
       model,
       emit.map(open => DropdownSetOpen(open)),
-      emit.map(index => DropdownSetActive(index)),
       emit.map(value => DropdownToggleChecked(value)),
       emit.map(pair => DropdownSetRadio(pair.0, pair.1)),
-      emit.map(value => DropdownSetSubmenu(value)),
     )
     menu_root_surface(
       "dropdown-menu",
@@ -235,8 +228,6 @@ pub fn dropdown_menu(
     menu_noop_emit(),
     menu_noop_emit(),
     menu_noop_emit(),
-    menu_noop_emit(),
-    menu_noop_emit(),
   )
   @rabbita.Val::constant(
     menu_root_surface(

rui/interaction.mbt

@@ -323,61 +323,6 @@ fn ui_dialog_close(id : String) -> @cmd.Cmd {
   @cmd.none
 }
 
-///|
-#cfg(target="js")
-fn ui_dialog_request_close(id : String) -> @cmd.Cmd {
-  @cmd.custom_cmd(kind=@cmd.after_render, _ => {
-    if @dom.document().get_element_by_id(id).to_option() is Some(element) &&
-      element.to_html_element() is Some(html_element) &&
-      html_element.to_html_dialog_element() is Some(dialog) {
-      dialog.request_close()
-    }
-  })
-}
-
-///|
-#cfg(not(target="js"))
-fn ui_dialog_request_close(id : String) -> @cmd.Cmd {
-  ignore(id)
-  @cmd.none
-}
-
-///|
-#cfg(target="js")
-fn ui_popover_show(id : String) -> @cmd.Cmd {
-  @cmd.custom_cmd(kind=@cmd.after_render, _ => {
-    if @dom.document().get_element_by_id(id).to_option() is Some(element) &&
-      element.to_html_element() is Some(html_element) {
-      html_element.show_popover()
-    }
-  })
-}
-
-///|
-#cfg(not(target="js"))
-fn ui_popover_show(id : String) -> @cmd.Cmd {
-  ignore(id)
-  @cmd.none
-}
-
-///|
-#cfg(target="js")
-fn ui_popover_hide(id : String) -> @cmd.Cmd {
-  @cmd.custom_cmd(kind=@cmd.after_render, _ => {
-    if @dom.document().get_element_by_id(id).to_option() is Some(element) &&
-      element.to_html_element() is Some(html_element) {
-      html_element.hide_popover()
-    }
-  })
-}
-
-///|
-#cfg(not(target="js"))
-fn ui_popover_hide(id : String) -> @cmd.Cmd {
-  ignore(id)
-  @cmd.none
-}
-
 ///|
 #cfg(target="js")
 fn ui_focus_id(id : String) -> @cmd.Cmd {

rui/menu_internal.mbt

@@ -17,19 +17,16 @@ enum MenuSubmenuChange {
 } derive(Eq)
 
 ///|
-struct MenuScope {
+priv struct MenuScope {
   id : String
   content_id : String
   trigger_id : String
   model : MenuCoreModel
   counter : Ref[Int]
-  open_command : @cmd.Cmd
   close_command : @cmd.Cmd
   toggle_command : @cmd.Cmd
-  set_active : @cmd.Emit[Int]
   toggle_checked : @cmd.Emit[String]
   set_radio : @cmd.Emit[(String, String)]
-  set_submenu : @cmd.Emit[MenuSubmenuChange]
 }
 
 ///|
@@ -242,6 +239,7 @@ fn menu_scope_next_index(scope : MenuScope) -> Int {
 }
 
 ///|
+#cfg(not(target="js"))
 fn[A] menu_noop_emit() -> @cmd.Emit[A] {
   @cmd.Emit(_ => @cmd.none)
 }

rui/menubar.mbt

@@ -12,13 +12,10 @@ struct MenubarScope {
   model : MenubarModel
   counter : Ref[Int]
   focus_claimed : Ref[Bool]
-  activate : @cmd.Emit[(String, Int)]
   toggle : @cmd.Emit[(String, Int)]
   close_command : @cmd.Cmd
-  set_active : @cmd.Emit[Int]
   toggle_checked : @cmd.Emit[String]
   set_radio : @cmd.Emit[(String, String)]
-  set_submenu : @cmd.Emit[MenuSubmenuChange]
 }
 
 ///|
@@ -570,26 +567,20 @@ fn menubar_trigger_id(id : String, index : Int) -> String {
 fn menubar_scope(
   id : String,
   model : MenubarModel,
-  activate : @cmd.Emit[(String, Int)],
   toggle : @cmd.Emit[(String, Int)],
   close_command : @cmd.Cmd,
-  set_active : @cmd.Emit[Int],
   toggle_checked : @cmd.Emit[String],
   set_radio : @cmd.Emit[(String, String)],
-  set_submenu : @cmd.Emit[MenuSubmenuChange],
 ) -> MenubarScope {
   {
     id,
     model,
     counter: Ref(0),
     focus_claimed: Ref(false),
-    activate,
     toggle,
     close_command,
-    set_active,
     toggle_checked,
     set_radio,
-    set_submenu,
   }
 }
 
@@ -686,7 +677,6 @@ pub fn menubar(
             (current, @cmd.none)
           } else {
             let next = {
-              ..current,
               active_value: Some(value),
               active_index: index,
               focus_index: index,
@@ -706,7 +696,6 @@ pub fn menubar(
           }
         MenubarSwitch(value, index) => {
           let next = {
-            ..current,
             active_value: Some(value),
             active_index: index,
             focus_index: index,
@@ -736,7 +725,6 @@ pub fn menubar(
           } else if current.active_value == Some(value) {
             (
               {
-                ..current,
                 active_value: None,
                 active_index: -1,
                 focus_index: index,
@@ -754,7 +742,6 @@ pub fn menubar(
             )
           } else {
             let next = {
-              ..current,
               active_value: Some(value),
               active_index: index,
               focus_index: index,
@@ -780,7 +767,6 @@ pub fn menubar(
           if current.active_value is Some(_) {
             (
               {
-                ..current,
                 active_value: None,
                 active_index: -1,
                 focus_index: current.active_index,
@@ -811,7 +797,6 @@ pub fn menubar(
             } else {
               (
                 {
-                  ..current,
                   active_value: Some(value),
                   active_index: index,
                   focus_index: index,
@@ -823,7 +808,6 @@ pub fn menubar(
           } else if current.active_value == Some(value) {
             (
               {
-                ..current,
                 active_value: None,
                 active_index: -1,
                 focus_index: index,
@@ -895,13 +879,10 @@ pub fn menubar(
     let scope = menubar_scope(
       id,
       model,
-      emit.map(pair => MenubarActivate(pair.0, pair.1)),
       emit.map(pair => MenubarToggle(pair.0, pair.1)),
       emit(MenubarClose),
-      emit.map(index => MenubarSetActive(index)),
       emit.map(value => MenubarToggleChecked(value)),
       emit.map(pair => MenubarSetRadio(pair.0, pair.1)),
-      emit.map(value => MenubarSetSubmenu(value)),
     )
     let element_attrs = menu_state_attrs(
         attrs,
@@ -962,12 +943,9 @@ pub fn menubar(
     id,
     model,
     menu_noop_emit(),
-    menu_noop_emit(),
     @cmd.none,
     menu_noop_emit(),
     menu_noop_emit(),
-    menu_noop_emit(),
-    menu_noop_emit(),
   )
   let element_attrs = menu_state_attrs(
       attrs,
@@ -1048,13 +1026,10 @@ pub fn[C : @html.IsChildren] menubar_menu(
     trigger_id: menubar_trigger_id(scope.id, index),
     model: menu_model,
     counter: Ref(0),
-    open_command: (scope.activate)((value, index)),
     close_command: scope.close_command,
     toggle_command: (scope.toggle)((value, index)),
-    set_active: scope.set_active,
     toggle_checked: scope.toggle_checked,
     set_radio: scope.set_radio,
-    set_submenu: scope.set_submenu,
   }
   @html.div(
     style=ui_styles([UiBoxSizing, "display:contents"], style),

rui/message_scroller.mbt

@@ -8,12 +8,12 @@ pub(all) enum MessageScrollDirection {
 priv struct MessageScrollerPosition {
   at_start : Bool
   at_end : Bool
-} derive(Debug, Eq)
+} derive(Eq)
 
 ///|
 priv enum MessageScrollerMsg {
   SetScrollerPosition(Bool, Bool)
-} derive(Debug)
+}
 
 ///|
 /// Opaque render scope owned by `message_scroller`.

rui/navigation_menu.mbt

@@ -14,9 +14,7 @@ struct NavigationMenuScope {
   viewport : Bool
   contents : Ref[Array[NavigationMenuContentEntry]]
   viewport_rendered : Ref[Bool]
-  activate : @cmd.Emit[(String, Int)]
   toggle : @cmd.Emit[(String, Int)]
-  close_command : @cmd.Cmd
 }
 
 ///|
@@ -30,9 +28,7 @@ struct NavigationMenuItemScope {
   active_value_set : Bool
   viewport : Bool
   contents : Ref[Array[NavigationMenuContentEntry]]
-  activate_command : @cmd.Cmd
   toggle_command : @cmd.Cmd
-  close_command : @cmd.Cmd
 }
 
 ///|
@@ -726,9 +722,7 @@ pub fn navigation_menu(
       viewport,
       contents: Ref([]),
       viewport_rendered: Ref(false),
-      activate: emit.map(pair => NavigationActivate(pair.0, pair.1)),
       toggle: emit.map(pair => NavigationToggle(pair.0, pair.1)),
-      close_command: emit(NavigationClose),
     }
     let element_attrs = menu_state_attrs(
       attrs,
@@ -798,9 +792,7 @@ pub fn navigation_menu(
     viewport,
     contents: Ref([]),
     viewport_rendered: Ref(false),
-    activate: menu_noop_emit(),
     toggle: menu_noop_emit(),
-    close_command: @cmd.none,
   }
   let element_attrs = menu_state_attrs(
     attrs,
@@ -902,9 +894,7 @@ pub fn[C : @html.IsChildren] navigation_menu_item(
     active_value_set: scope.model.value is Some(_),
     viewport: scope.viewport,
     contents: scope.contents,
-    activate_command: (scope.activate)((value, index)),
     toggle_command: (scope.toggle)((value, index)),
-    close_command: scope.close_command,
   }
   @html.li(
     style=ui_styles([UiBoxSizing, NavigationMenuItemStyle], style),

rui/pkg.generated.mbti

@@ -1072,8 +1072,6 @@ type MenuCoreModel derive(Eq)
 
 type MenuIndicatorPlacement derive(Eq)
 
-type MenuScope
-
 type MenuSubmenuChange derive(Eq)
 
 type MenubarMenuScope