Vdom diff fail to detect disabled property change

[tonyfettes]

I was adding disabled property to the button view:

///|
pub fn button[M](
  disabled? : Bool,
  style~ : Array[String] = [],
  id? : String,
  class? : String,
  click? : M,
  childrens : Array[Html[M]]
) -> Html[M] {
  let attrs = []
  if click is Some(click) {
    attrs.push(on_click(fn(_) { click }))
  }
  if disabled is Some(true) {
    attrs.push(property("disabled", Boolean(true)))
  }
  common_node(style~, class?, id?, "button", attrs, childrens)
}

And it fails to update the button from disabled=true to disabled=false.

[AnNingUI]

I was adding disabled property to the button view:我正在向按钮视图添加 disabled 属性：

///|
pub fn button[M](
disabled? : Bool,
style~ : Array[String] = [],
id? : String,
class? : String,
click? : M,
childrens : Array[Html[M]]
) -> Html[M] {
let attrs = []
if click is Some(click) {
attrs.push(on_click(fn(_) { click }))
}
if disabled is Some(true) {
attrs.push(property("disabled", Boolean(true)))
}
common_node(style~, class?, id?, "button", attrs, childrens)
}
And it fails to update the button from disabled=true to disabled=false.并且它无法将按钮从 disabled=true 更新为 disabled=false。

我认为你应该将

if disabled is Some(true) {
    attrs.push(property("disabled", Boolean(true)))
 }

改为

// 这是src/html/html.mbt中select的做法
if disabled is Some(value) {
    attrs.push(property("disabled", Boolean(value)))
 }

或者

// 在html规范中disabled只要在attr中存在就为disabled，即使disabled="false"
if disabled is Some(true) {
    attrs.push(attribute("disabled", ""))
 }