CODE_VERSION not being correctly added to build; uses fallback random value

[jrgm]

Do the following:

curl -s https://static.login.persona.org/v/d22163913e/production/en/browserid.js | perl -ne 'next unless /(CODE_VERSION=.*?),/; print $1, $/'
CODE_VERSION="R94gwfP"

That is a randomly generated value from secrets.weakGenerate(7) used when the ver.txt git sha cannot be found.

This leads to these warnings in the logs:

{"level":"warn","message":"Code version mis-match: /session_context expected: N33PJT2 received: R94gwfP","timestamp":"2015-10-16T23:49:39.974Z"}

Something is broken in the build process. I'm unclear what effect this has aside from log whining.

Anyone?

[relud]

this is probably a direct result of me using a different build process, and not noticing the log whining before. It looks like I'm supposed to put the ver.txt in place before running scripts/compress but in the currently used build process, it comes last.

[relud]

nevermind, changing the order doesn't appear to effect the minified localized js in the rpm.