Hey. I have made a fork of android-tools. One of its goals was to introduce Windows support. I've used MSYS2 as my main source of inspiration. To be able to fully adapt it, I had to "fork" this repository too. My repository can be found at
https://github.com/meator/AdbWinApi
I have made that repo mostly for the benefit of my android-tools fork (located at meator/android-tools-static), but it should be fully usable for MSYS2 too.
I figured that I'd message you since this is the repo which I've used for inspiration when writing https://github.com/meator/AdbWinApi. If you are interested, we could work on using my repository as source of AdbWinApi .dlls in MSYS2. I don't see a reason to duplicate our efforts in maintaining two versions of AdbWinApi. If there's interest, I'd like to contribute.
In comparison to msys2/adbwinapi, my repository brings the following features:
-
A robust build process.
The build process of my fork is handled by GitHub Workflows from start to finish. This aids build provenance and reproducibility (not full binary reproducibility).
The current release process of msys2/adbwinapi isn't as robust. It isn't documented (I assume) and it requires manually creating releases and manually uploading build results, which may be prone to error and is less transparent.
My repository takes transparency seriously by producing SBOMs for prebuilt release artifacts (although SBOMs are likely irrelevant for MSYS2 packaging).
-
Better documentation
https://github.com/meator/AdbWinApi's README is much more detailed.
-
Fixed FTBFS with recent MSVC
meator/AdbWinApi adds the following patch: https://github.com/meator/AdbWinApi/blob/ebe7af07896e61a030a0c2e9448b95869af75695/build_template/subprojects/packagefiles/diff_files/0001-fix-bool-to-ptr-implicit-cast-errors.patch
This is a minor issue, this patch could be easily incorporated into msys2/adbwinapi
-
Verbose error messages
My Meson build system tries to print meaningful error messages (mostly here). AdbWinApi is small and simple enough, these verbose error messages probably do not matter that much.
Hey. I have made a fork of android-tools. One of its goals was to introduce Windows support. I've used MSYS2 as my main source of inspiration. To be able to fully adapt it, I had to "fork" this repository too. My repository can be found at
https://github.com/meator/AdbWinApi
I have made that repo mostly for the benefit of my android-tools fork (located at meator/android-tools-static), but it should be fully usable for MSYS2 too.
I figured that I'd message you since this is the repo which I've used for inspiration when writing https://github.com/meator/AdbWinApi. If you are interested, we could work on using my repository as source of AdbWinApi
.dlls in MSYS2. I don't see a reason to duplicate our efforts in maintaining two versions of AdbWinApi. If there's interest, I'd like to contribute.In comparison to msys2/adbwinapi, my repository brings the following features:
A robust build process.
The build process of my fork is handled by GitHub Workflows from start to finish. This aids build provenance and reproducibility (not full binary reproducibility).
The current release process of msys2/adbwinapi isn't as robust. It isn't documented (I assume) and it requires manually creating releases and manually uploading build results, which may be prone to error and is less transparent.
My repository takes transparency seriously by producing SBOMs for prebuilt release artifacts (although SBOMs are likely irrelevant for MSYS2 packaging).
Better documentation
https://github.com/meator/AdbWinApi's README is much more detailed.
Fixed FTBFS with recent MSVC
meator/AdbWinApi adds the following patch: https://github.com/meator/AdbWinApi/blob/ebe7af07896e61a030a0c2e9448b95869af75695/build_template/subprojects/packagefiles/diff_files/0001-fix-bool-to-ptr-implicit-cast-errors.patch
This is a minor issue, this patch could be easily incorporated into msys2/adbwinapi
Verbose error messages
My Meson build system tries to print meaningful error messages (mostly here). AdbWinApi is small and simple enough, these verbose error messages probably do not matter that much.