Support editing/deleting messages for public guests

[jospoortvliet]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. create a public link room
2. join in anonymous browsing mode as guest
3. write a message
4. try to edit or delete it - the option isn't in the menu 😢

Expected behaviour

Editing should be possible, but it's not

Talk app

Talk app version:
I don't know the specific Talk app. But I have seen this happen on a server running 30.0.11.2 and our company instance on 33.0.0.16 and latest everything.

Browser

Browsers both Safari and Chrome on Mac OS

[Antreesy]

There's a blocker on frontend isConversationModifiable that returns false for guests. But even if overriden, server request fails with 404.

I remember we coded it according to attibutes, and RequireAuthenticatedParticipant should block it for guests anyway?

spreed/lib/Controller/ChatController.php

Lines 1357 to 1369 in 00fd387

	#[FederationSupported]
	#[PublicPage]
	#[RequireModeratorOrNoLobby]
	#[RequireAuthenticatedParticipant]
	#[RequirePermission(permission: RequirePermission::CHAT)]
	#[RequireReadWriteConversation]
	#[RequestHeader(name: 'x-nextcloud-federation', description: 'Set to 1 when the request is performed by another Nextcloud Server to indicate a federation request', indirect: true)]
	#[ApiRoute(verb: 'PUT', url: '/api/{apiVersion}/chat/{token}/{messageId}', requirements: [
	'apiVersion' => '(v1)',
	'token' => '[a-z0-9]{4,30}',
	'messageId' => '[0-9]+',
	])]
	public function editMessage(int $messageId, string $message): DataResponse {

[nickvergessen]

Ah, I misread from #[PublicPage] then, but I guess that is required for federation this way.