feat: add app-id-regex-substring matcher for window filtering#1860
Open
oomathias wants to merge 3 commits intonikitabobko:mainfrom
Open
feat: add app-id-regex-substring matcher for window filtering#1860oomathias wants to merge 3 commits intonikitabobko:mainfrom
oomathias wants to merge 3 commits intonikitabobko:mainfrom
Conversation
What: WindowDetectedCallbackMatcher now supports regex substring matching on window.app.rawAppBundleId via appIdRegexSubstring property. Why: Enable targeting multiple related apps with patterns like "com.apple.*" instead of exact bundle ID matches. How: - Adds appIdRegexSubstring property with case-insensitive regex parsing - Matches when regex is nil fail - Updates description and equality implementations - Includes test coverage Use cases: - "com.apple.*" targets all Apple applications - "com.company.*" targets all apps from specific vendor - ".*slack.*" matches apps containing "slack" in bundle ID Signed-off-by: Mathias Beugnon <mathias@beugnon.fr>
f022281 to
e42d092
Compare
Davincible
added a commit
to Davincible/AeroSpace
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Allows regex matching on bundle ID for
on-window-detectedcallback.Why:
Enable targeting multiple related apps with patterns like "com.apple.*" instead of exact bundle ID matches.
How:
Use cases:
PR checklist
./run-tests.shexits with non-zero exit code.Failure to follow the checklist with no apparent reasons will result in silent PR rejection.