assert: address review feedback

Author: AbdelrahmanHafez

lib/internal/assert/assertion_error.js

@@ -47,6 +47,7 @@ const kMaxLongStringLength = 512;
 // Objects with many converging paths can produce exponential growth in
 // util.inspect output at high depths, leading to OOM during diff generation.
 const kMaxInspectOutputLength = 2 * 1024 * 1024; // 2MB
+const kTruncatedByteMarker = '\n... [truncated]';
 
 const kMethodsWithCustomMessageDiff = new SafeSet()
   .add('deepStrictEqual')
@@ -74,7 +75,7 @@ function copyError(source) {
   return target;
 }
 
-function inspectValue(val, maxLength = kMaxInspectOutputLength) {
+function inspectValue(val) {
   // The util.inspect default values could be changed. This makes sure the
   // error messages contain the necessary information nevertheless.
   const result = inspect(val, {
@@ -95,8 +96,9 @@ function inspectValue(val, maxLength = kMaxInspectOutputLength) {
   // Objects with deeply nested structures can produce exponentially large
   // inspect output that causes memory exhaustion when passed to the diff
   // algorithm.
-  if (result.length > maxLength) {
-    return StringPrototypeSlice(result, 0, maxLength) + '\n... [truncated]';
+  if (result.length > kMaxInspectOutputLength) {
+    return StringPrototypeSlice(result, 0, kMaxInspectOutputLength) +
+      kTruncatedByteMarker;
   }
   return result;
 }
@@ -205,9 +207,8 @@ function createErrDiff(actual, expected, operator, customMessage, diffType = 'si
   const inspectedExpected = inspectValue(expected);
 
   // Check if either value was truncated due to size limits
-  const truncationMarker = '\n... [truncated]';
-  if (StringPrototypeEndsWith(inspectedActual, truncationMarker) ||
-      StringPrototypeEndsWith(inspectedExpected, truncationMarker)) {
+  if (StringPrototypeEndsWith(inspectedActual, kTruncatedByteMarker) ||
+      StringPrototypeEndsWith(inspectedExpected, kTruncatedByteMarker)) {
     skipped = true;
   }
   const inspectedSplitActual = StringPrototypeSplit(inspectedActual, '\n');