consult-preview-at-point-mode is obsolete

[hmelman]

consult-preview-at-point-mode is now obsolete and should probably be removed from the recommended setup in the README.

[minad]

Fixed by #788

[oantolin]

I am confused! I thought it isn't obsolete yet (I thought it was still useful for people using the *Completions* buffer on Emacs <31) but would become obsolete once #788 is merged. Am I misunderstanding?

[hmelman]

I changed my init and got a warning compiling it, I was binding consult-preview-at-point in embark-collect-mode-map (though I never use it). I saw the consult commit which also obsoleted consult-preview-at-point-mode and also looked at embark. Maybe I got something wrong. I didn't find the obsolete message particularly helpful.

hrm-completion.el:623:46: Warning: `consult-preview-at-point' is an obsolete
    function (as of Obsolete since preview is enabled automatically.).

[oantolin]

Ah, OK. "as of Obsolete since preview is enabled automatically" is funny.

[minad]

To be clear, the automatically enabled Consult preview only affects Embark live collect from the minibuffer, which is a rarely used feature. embark-live can be used also from a regular buffer. I guess we could probably remove embark-live without losing much.