Skip to content

EmonCMS HTTPs fingerprint is not treated correctly #101

@llpamies

Description

@llpamies

I think that in emoncms.cpp, in this section:

    // Send data to Emoncms server
    String result = "";
    if (emoncms_fingerprint.isEmpty())
    {
      // HTTPS on port 443 if HTTPS fingerprint is present
      DBUGLN(F("HTTPS Enabled"));
      result =
        get_https(emoncms_fingerprint.c_str(), emoncms_server.c_str(), url,
                  443);
    }
    else
    {
      // Plain HTTP if other emoncms server e.g EmonPi
      DBUGLN(F("Plain old HTTP"));
      result = get_http(emoncms_server.c_str(), url);
    }

The condition should instead be:

    if (!emoncms_fingerprint.isEmpty())

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions