Skip to content

Buckingham VSite handler tries to get parameters by SMIRKS #1457

@lilyminium

Description

@lilyminium

Description

Probably not a common scenario, but smee tests have uncovered that the Buckingham VSite handler still tries to get parameters by SMIRKS only, which is no longer supported.

# TODO: This logic assumes no spaces in the SMIRKS pattern, name or `match` attribute
smirks, _, _ = potential_key.id.split(" ")
parameter = parameter_handler.parameters[smirks]

Reproduction

Please include a minimally reproducing example of this bug.

See CI here: https://github.com/openforcefield/smee/actions/runs/22615205684/job/65526240736?pr=140

Output

Please include the output, including full tracebacks of any errors, resulting from the reproduction.

Software versions

  • Which operating system and version are you using?
  • How did you install Interchange?
  • What is the output of running conda list?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions