luci-app-upnp: Warning about a current PR which does not respect the OpenWrt "Submission Guidelines" | Same for "miniupnpd" package

[Neustradamus]

Dear OpenWrt team,

There is a problem, a guy has specified my comment like spam but it is not and it is very important to read and to understand the current situation.

Two PRs do not respect the OpenWrt "Submission Guidelines":

• luci-app-upnp: Revision, new network access control and UCI options… #7822
• miniupnpd: Update, revision, new network access control and UCI options… packages#24988

---

To follow my comment here: openwrt/packages#24988 (comment)

To follow my initial comment published here: #7822 (comment)

I have done a new detailled comment here: #7822 (comment)

---

RECALL:

• Self-Hosting-Group has been banned by miniupnp team.
• I have already informed the PR author about the needed changes (nothing must be merged before changes).

The OpenWrt "Submission Guidelines" is here and clear:

• https://openwrt.org/submitting-patches

It is specified:

• all commits must contain Signed-off-by: My Name <my@email.address> where you write your real name and real email address, in accordance with Section 11 of the Linux Kernel patches guide: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=HEAD#n416
• GitHub web interface or GUI application for git: you must append the Signed-off-by: line manually in the commit description
• git command-line interface:
  git commit --signoff
• the Author field must match the Signed-off-by: line
• GitHub web interface: you must specify your real name in the Name field and the Primary email address to match the Signed-off-by: line
• git command-line interface:
  git config --global user.name "my name"
git config --global user.email "my@email.address"

---

Attention: To add more informations, warnings specified in my previous comment are here, it is not from me (I have previously cited only the latest one), GitHub Actions bot do a good work to specify the problem:

github-actions bot:
- /!\ Warning
- Some formality checks failed.
- Consider (re)reading submissions guidelines.

Several times here:

• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)
• luci-app-upnp: Revision, new network access control and UCI options… #7822 (comment)

🔶 Author name (Self-Hosting-Group) seems to be a nickname or an alias
🔶 Committer name (Self-Hosting-Group) seems to be a nickname or an alias

Linked to:

• miniupnpd: Warning about a current PR which does not respect the OpenWrt "Submission Guidelines" packages#28321