refers to Theoretical Key Collision in remove_duplicates_by_uniques

[atheendre130505]

issue: #3632
pr: #3639
@shlokgilda @MoralCode : I detected these inconsistencies going thru a code audit. Still wondering what could be a better alternative to the proposed pr.

[MoralCode]

Id be curious to learn more about the process you went through for the code audit (i.e. what tools you were using/what the audit was looking for) since theres many different kinds of audits out there.

I dont doubt that this change is useful/a valid improvement, but since Shlok mentioned that the function doesnt get called with values containing underscores, This fix is likely much lower priority than other active bugs and feature improvements that are currently being worked on.

Happy to chat more about this if you are looking for more things to contribute to the project (just note that we did not apply to be part of GSoC this year in case that was your primary motivation)

[atheendre130505]

I stumbled on it while trying to find issues with the code, I frequently test out different functions and files, the audit was looking for improvements/bugs in code.
I am new to this repo and github, and am looking to contribute and learn as much as possible, and yes i am well aware of OFF not being part of GSoC).

[MoralCode]

Was there a particular test procedure you ran to discover this issue in the duplicate removal? i.e. something that I could reproduce on my machine or get a stack trace from?

[atheendre130505]

@MoralCode Nothing in particular, ran into it by luck, was looking for inconsistencies in output in functions and files output in particular.

[MoralCode]

were you looking at the code and noticed this? or did it come up while Augur was running?

[MoralCode]

it sounds like based on your intiail description that it happened in a code audit