Solid.js (eslint-plugin-solid) built-in plugin

[agoldstein03]

Not sure if this is still the requested pattern (following https://oxc.rs/docs/guide/usage/linter/plugins.html#adding-new-plugins), but thoughts on including Solid.js built-in support, for parity with React? I haven't looked too much in detail at the React implementation specifics it would just be great to ensure that JSX support is agnostic moving forward, and continues to work well with non-React JSX like Solid.js.

Apologies if this is the wrong place/structure, thanks y'all for some really great work here!

[kanashimia]

Note that oxlint aims to support existing js plugins, eslint-plugin-solid seems to work

Example config is something like this:

.oxlintrc.jsonc

{
  "jsPlugins": ["eslint-plugin-solid"],
  "rules": {
    // identifier usage is important
    "solid/jsx-no-duplicate-props": 2,
    "solid/jsx-no-undef": [2, { "typescriptEnabled": true }],
    "solid/jsx-uses-vars": 2,
    "solid/no-unknown-namespaces": 0,
    // security problems
    "solid/no-innerhtml": 2,
    "solid/jsx-no-script-url": 2,
    // reactivity
    "solid/components-return-once": 1,
    "solid/no-destructure": 2,
    "solid/prefer-for": 2,
    "solid/reactivity": 1,
    "solid/event-handlers": 1,
    // these rules are mostly style suggestions
    "solid/imports": 1,
    "solid/style-prop": 1,
    "solid/no-react-deps": 1,
    "solid/no-react-specific-props": 1,
    "solid/self-closing-comp": 1,
    "solid/no-array-handlers": 0,
    // handled by Solid compiler, opt-in style suggestion
    "solid/prefer-show": 0,
    // only necessary for resource-constrained environments
    "solid/no-proxy-apis": 0,
    // deprecated
    "solid/prefer-classlist": 0,
  },
  "plugins": ["eslint", "typescript", "unicorn", "node", "promise", "import", "jsx-a11y", "oxc"],
}

Rules copied from the default eslint-plugin-solid typescript preset.

Adding a native plugin would just be a performance optimization.

I imagine porting wouldn't be difficult though, there aren't a lot of rules, and they aren't complicated.

[camc314]

kanashimia is correct here - the JS plugin should work, and that is the suggested way to use the solid plugin.

Please see https://oxc.rs/docs/guide/usage/linter/plugins.html#adding-new-plugins for notes on implementing this as a native plugin.

[blopker]

Hey! I just ran into this issue as well. I didn't want to have to add all the rules into the .oxlintrc.jsonc file though, so I came up with a little hack using the oxlint.config.ts alternative that pulls the recommended rules directly from the solidjs plugin. Thought I'd share a minimal example in case someone else ran into this:

// oxlint.config.ts
import { defineConfig } from "oxlint"
import solid from "eslint-plugin-solid/configs/typescript"

export default defineConfig({
  jsPlugins: ["eslint-plugin-solid"],
  rules: {
    ...solid.rules, // stays in sync with eslint-plugin-solid on upgrade
  },
})

Seems to work on the cli and in Zed with the oxc extension installed. Cheers!

[camc314]

Thanks for sharing! - yep this should work!