Skip to content

Custom flavor builder action does not account for repository names with uppercase charactersΒ #7325

@dwandro

Description

@dwandro

Describe the bug

The custom flavor builder CLI generates workflows which call the custom flavor builder action with CUSTOM_FLAVOR_BUILD_REPO: ${{ github.repository }}. When this is used from a repo which contains capital letters in the owner (organization or user) or repository name, it results in a job failure because Docker does not allow uppercase characters in image names.

When setting the environment variable value to use all lowercase (statically or dynamically), the build succeeds, but the job still fails because the Tag and Push Docker Image step still uses ${{ github.repository }} directly as opposed to using the input.

To Reproduce
Steps to reproduce the behavior:

  1. Create a repository with uppercase characters in the repo name
  2. Call the action with CUSTOM_FLAVOR_BUILD_REPO: ${{ github.repository }}
  3. Run the build and encounter the first issue described above.
  4. Set the value statically to all lowecase.
  5. Run the build and encounter the second issue described above

Expected behavior
The input should be converted to lowercase and used consistently to avoid this problem

Screenshots
N/A

Additional context
N/A

Metadata

Metadata

Labels

O: stale πŸ€–This issue or pull request is stale, it will be closed if there is no activitybugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions