[pre-commit.ci] pre-commit autoupdate (#2703)

<!--pre-commit.ci start-->
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.9.2 →
v0.14.5](astral-sh/ruff-pre-commit@v0.9.2...v0.14.5)
- [github.com/pre-commit/mirrors-mypy: v1.14.1 →
v1.18.2](pre-commit/mirrors-mypy@v1.14.1...v1.18.2)
- [github.com/pre-commit/pre-commit-hooks: v5.0.0 →
v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0)
- [github.com/shellcheck-py/shellcheck-py: v0.10.0.1 →
v0.11.0.1](shellcheck-py/shellcheck-py@v0.10.0.1...v0.11.0.1)
- [github.com/packit/pre-commit-hooks: v1.2.0 →
v1.3.0](packit/pre-commit-hooks@v1.2.0...v1.3.0)
- [github.com/packit/requre: 0.8.4 →
0.9.1](packit/requre@0.8.4...0.9.1)
- [github.com/gitleaks/gitleaks: v8.23.1 →
v8.29.0](gitleaks/gitleaks@v8.23.1...v8.29.0)
- [github.com/python-jsonschema/check-jsonschema: 0.31.0 →
0.35.0](python-jsonschema/check-jsonschema@0.31.0...0.35.0)
<!--pre-commit.ci end-->

Author: nforro

.pre-commit-config.yaml

@@ -4,13 +4,13 @@
 
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.9.2
+    rev: v0.14.5
     hooks:
       - id: ruff
         args: [--fix, --exit-non-zero-on-fix]
       - id: ruff-format
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.14.1
+    rev: v1.18.2
     hooks:
       - id: mypy
         args: [
@@ -41,7 +41,7 @@ repos:
       - id: prettier
         exclude: tests_openshift/openshift_integration/test_data/
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v5.0.0
+    rev: v6.0.0
     hooks:
       - id: check-added-large-files
       - id: check-ast
@@ -60,18 +60,18 @@ repos:
       - id: mixed-line-ending
       - id: trailing-whitespace
   - repo: https://github.com/shellcheck-py/shellcheck-py
-    rev: v0.10.0.1
+    rev: v0.11.0.1
     hooks:
       - id: shellcheck
   - repo: https://github.com/packit/pre-commit-hooks
-    rev: v1.2.0
+    rev: v1.3.0
     hooks:
       - id: check-rebase
         args:
           - https://github.com/packit/packit-service.git
         stages: [manual, pre-push]
   - repo: https://github.com/packit/requre
-    rev: 0.8.4
+    rev: 0.9.1
     hooks:
       - id: requre-purge
         name: Requre response files cleanup
@@ -96,14 +96,14 @@ repos:
         files: /tests_openshift.*\.yaml$
         stages: [manual, pre-push]
   - repo: https://github.com/gitleaks/gitleaks
-    rev: v8.23.1
+    rev: v8.29.0
     hooks:
       - id: gitleaks
         # The hook runs 'gitleaks protect --staged' which parses output of
         # 'git diff --staged', i.e. always passes in pre-push/manual stage.
         stages: [pre-commit]
   - repo: https://github.com/python-jsonschema/check-jsonschema
-    rev: 0.31.0
+    rev: 0.35.0
     hooks:
       - id: check-github-workflows
         args: ["--verbose"]

packit_service/worker/handlers/testing_farm.py

@@ -249,7 +249,7 @@ def run_with_copr_builds(self, targets: list[str], failed: dict):
         if not targets_with_builds:
             return
 
-        group, test_runs = self._get_or_create_group(targets_with_builds)
+        _, test_runs = self._get_or_create_group(targets_with_builds)
         for test_run in test_runs:
             copr_build = test_run.copr_builds[0]
             if copr_build.status in (
@@ -326,8 +326,8 @@ def run(self) -> TaskResults:
         failed: dict[str, str] = {}
 
         if self.testing_farm_job_helper.skip_build:
-            group, test_runs = self._get_or_create_group(
-                {target: None for target in targets},
+            _, test_runs = self._get_or_create_group(
+                dict.fromkeys(targets),
             )
             for test_run in test_runs:
                 # Only retry what's needed
@@ -467,7 +467,7 @@ def run(self) -> TaskResults:
             self.service_config, self.project, self.data
         )
 
-        group, test_runs = self._get_or_create_group(fedora_ci_tests)
+        _, test_runs = self._get_or_create_group(fedora_ci_tests)
         for test_run in test_runs:
             # Only retry what's needed
             if test_run.status not in [

packit_service/worker/reporting/__init__.py

@@ -25,5 +25,5 @@
     StatusReporterGithubStatuses.__name__,
     StatusReporterGitlab.__name__,
     create_issue_if_needed.__name__,
-    comment_without_duplicating,
+    comment_without_duplicating.__name__,
 ]

tests/integration/test_bodhi_update.py

@@ -142,7 +142,7 @@ def test_bodhi_update_for_unknown_koji_build(koji_build_completed_old_format):
     # 1*CreateBodhiUpdateHandler + 1*KojiBuildReportHandler
     assert len(processing_results) == 2
     processing_results.pop()
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -247,7 +247,7 @@ def test_bodhi_update_for_unknown_koji_build_failed(koji_build_completed_old_for
     # 1*CreateBodhiUpdateHandler + 1*KojiBuildReportHandler
     assert len(processing_results) == 2
     processing_results.pop()
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     with pytest.raises(PackitException):
@@ -358,7 +358,7 @@ def test_bodhi_update_for_unknown_koji_build_failed_issue_created(
     # 1*CreateBodhiUpdateHandler + 1*KojiBuildReportHandler
     assert len(processing_results) == 2
     processing_results.pop()
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     CreateBodhiUpdateHandler(
@@ -483,7 +483,7 @@ def test_bodhi_update_for_unknown_koji_build_failed_issue_comment(
     # 1*CreateBodhiUpdateHandler + 1*KojiBuildReportHandler
     assert len(processing_results) == 2
     processing_results.pop()
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     CreateBodhiUpdateHandler(
@@ -598,7 +598,7 @@ def test_bodhi_update_build_not_tagged_yet(
     # 1*CreateBodhiUpdateHandler + 1*KojiBuildReportHandler
     assert len(processing_results) == 2
     processing_results.pop()
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     celery_task = flexmock(CeleryTask)
@@ -791,7 +791,7 @@ def test_bodhi_update_for_known_koji_build(koji_build_completed_old_format):
     # 1*CreateBodhiUpdateHandler + 1*KojiBuildReportHandler
     assert len(processing_results) == 2
     processing_results.pop()
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -943,7 +943,7 @@ def test_bodhi_update_fedora_stable_by_default(koji_build_completed_f36):
     # 1*CreateBodhiUpdateHandler + 1*KojiBuildReportHandler
     assert len(processing_results) == 2
     processing_results.pop()
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -1190,7 +1190,7 @@ def _create(target, koji_nvrs, sidetag, status, bodhi_update_group):
     flexmock(BodhiUpdateTargetModel).should_receive("create").replace_with(_create)
 
     processing_results = SteveJobs().process_message(koji_build_tagged)
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)

tests/integration/test_check_rerun.py

@@ -291,7 +291,7 @@ def test_check_rerun_pr_testing_farm_handler(
     flexmock(Pushgateway).should_receive("push").times(2).and_return()
 
     processing_results = SteveJobs().process_message(check_rerun_event_testing_farm)
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -349,7 +349,7 @@ def test_check_rerun_pr_koji_build_handler(
     flexmock(Pushgateway).should_receive("push").times(2).and_return()
 
     processing_results = SteveJobs().process_message(check_rerun_event_koji_build)
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -408,7 +408,7 @@ def test_check_rerun_pr_koji_build_handler_old_job_name(
     flexmock(Pushgateway).should_receive("push").times(2).and_return()
 
     processing_results = SteveJobs().process_message(check_rerun_event_koji_build)
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -494,7 +494,7 @@ def test_check_rerun_push_testing_farm_handler(
     flexmock(Pushgateway).should_receive("push").times(2).and_return()
 
     processing_results = SteveJobs().process_message(check_rerun_event_testing_farm)
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert event_dict["tests_targets_override"] == [("fedora-rawhide-x86_64", None)]
@@ -554,7 +554,7 @@ def test_check_rerun_push_koji_build_handler(
     flexmock(Pushgateway).should_receive("push").times(2).and_return()
 
     processing_results = SteveJobs().process_message(check_rerun_event_koji_build_push)
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert event_dict["build_targets_override"] == [("f34", None)]
@@ -613,7 +613,7 @@ def test_check_rerun_release_koji_build_handler(
     flexmock(Pushgateway).should_receive("push").times(2).and_return()
 
     processing_results = SteveJobs().process_message(check_rerun_event_koji_build)
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert event_dict["build_targets_override"] == [("f34", None)]
@@ -676,7 +676,7 @@ def test_check_rerun_release_propose_downstream_handler(
     processing_results = SteveJobs().process_message(
         check_rerun_event_propose_downstream,
     )
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, _, _ = get_parameters_from_results(
         processing_results,
     )
     assert event_dict["branches_override"] == ["f34"]

tests/integration/test_commit_comment.py

@@ -142,7 +142,7 @@ def test_commit_comment_build_and_test_handler(
     test_job = [item for item in processing_results if item["details"]["job"] == "tests"]
     assert test_job
 
-    event_dict, job, job_config, package_config = get_parameters_from_results(test_job)
+    event_dict, _, job_config, package_config = get_parameters_from_results(test_job)
     assert json.dumps(event_dict)
     results = run_testing_farm_handler(
         package_config=package_config,

tests/integration/test_dg_commit.py

@@ -126,7 +126,7 @@ def test_sync_from_downstream():
     )
 
     processing_results = SteveJobs().process_message(distgit_commit_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -345,7 +345,7 @@ def test_downstream_koji_build(sidetag_group):
         koji_target=sidetag if sidetag_group else None,
     ).and_return("")
     processing_results = SteveJobs().process_message(distgit_commit_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -450,7 +450,7 @@ def test_downstream_koji_build_failure_no_issue():
     pagure_project_mock.should_receive("create_issue").times(0)
 
     processing_results = SteveJobs().process_message(distgit_commit_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -558,7 +558,7 @@ def test_downstream_koji_build_failure_issue_created():
     ).once()
 
     processing_results = SteveJobs().process_message(distgit_commit_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -681,7 +681,7 @@ def test_downstream_koji_build_failure_issue_comment():
     issue_project_mock.should_receive("create_issue").times(0)
 
     processing_results = SteveJobs().process_message(distgit_commit_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -866,7 +866,7 @@ def test_downstream_koji_build_where_multiple_branches_defined(jobs_config):
 
     processing_results = SteveJobs().process_message(distgit_commit_event())
     assert len(processing_results) == 1
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)

tests/integration/test_dg_pr.py

@@ -152,7 +152,7 @@ def test_downstream_koji_scratch_build(distgit_pr_event, target_branch, uid, che
     ).once()
 
     processing_results = SteveJobs().process_message(distgit_pr_event)
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)

tests/integration/test_github_fas_verification.py

@@ -56,7 +56,7 @@ def test_verification_successful():
     flexmock(GithubProject).should_receive("get_issue").and_return(issue)
 
     processing_results = SteveJobs().process_message(issue_comment_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -118,7 +118,7 @@ def test_verification_not_successful():
     flexmock(GithubProject).should_receive("get_issue").and_return(issue)
 
     processing_results = SteveJobs().process_message(issue_comment_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -188,7 +188,7 @@ def test_verification_incorrect_format(comment):
     flexmock(GithubProject).should_receive("get_issue").and_return(issue)
 
     processing_results = SteveJobs().process_message(event_issue_comment)
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -242,7 +242,7 @@ def test_verification_already_approved():
     flexmock(GithubProject).should_receive("get_issue").and_return(issue)
 
     processing_results = SteveJobs().process_message(issue_comment_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -289,7 +289,7 @@ def test_verification_wrong_repository():
     flexmock(GithubProject).should_receive("get_issue").and_return(issue)
 
     processing_results = SteveJobs().process_message(issue_comment_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, _, _ = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -317,7 +317,7 @@ def test_verification_wrong_issue():
     flexmock(GithubProject).should_receive("get_issue").and_return(issue)
 
     processing_results = SteveJobs().process_message(issue_comment_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, _, _ = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)
@@ -349,7 +349,7 @@ def test_verification_not_original_triggerer():
     flexmock(GithubProject).should_receive("get_issue").and_return(issue)
 
     processing_results = SteveJobs().process_message(issue_comment_event())
-    event_dict, job, job_config, package_config = get_parameters_from_results(
+    event_dict, _, job_config, package_config = get_parameters_from_results(
         processing_results,
     )
     assert json.dumps(event_dict)