Skip to content

Commit 7480b4f

Browse files
centosinfra-prod-github-app[bot]centosinfra-prod-github-app[bot]
authored
Make Fedora CI check names more compact (#2955)
Make Fedora CI check names more compact Leave out the "test(s)" suffix in test status checks, as it is implied and doing so makes the status check names shorter. Reviewed-by: gemini-code-assist[bot] Reviewed-by: Maja Massarini
2 parents e7b4fe7 + 33c87d2 commit 7480b4f

4 files changed

Lines changed: 26 additions & 26 deletions

File tree

‎packit_service/worker/helpers/testing_farm.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1356,7 +1356,7 @@ def ci_helper(self) -> FedoraCIHelper:
13561356

13571357
@staticmethod
13581358
def get_check_name(test_name: str) -> str:
1359-
return f"Packit - {test_name} test(s)"
1359+
return f"Packit - {test_name}"
13601360

13611361
def report(
13621362
self,

‎tests/integration/test_listen_to_fedmsg.py‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2944,56 +2944,56 @@ def test_koji_build_end_downstream(
29442944
state=BaseCommitStatus.running,
29452945
description="Submitting the tests ...",
29462946
url="https://dashboard.localhost/jobs/testing-farm/5",
2947-
check_name="Packit - installability test(s)",
2947+
check_name="Packit - installability",
29482948
target_branch="rawhide",
29492949
).once()
29502950
flexmock(StatusReporter).should_receive("set_status").with_args(
29512951
state=BaseCommitStatus.running,
29522952
description="Tests have been submitted ...",
29532953
url="https://dashboard.localhost/jobs/testing-farm/5",
2954-
check_name="Packit - installability test(s)",
2954+
check_name="Packit - installability",
29552955
target_branch="rawhide",
29562956
).once()
29572957
flexmock(StatusReporter).should_receive("set_status").with_args(
29582958
state=BaseCommitStatus.running,
29592959
description="Submitting the tests ...",
29602960
url="https://dashboard.localhost/jobs/testing-farm/6",
2961-
check_name="Packit - custom test(s)",
2961+
check_name="Packit - custom",
29622962
target_branch="rawhide",
29632963
).once()
29642964
flexmock(StatusReporter).should_receive("set_status").with_args(
29652965
state=BaseCommitStatus.running,
29662966
description="Tests have been submitted ...",
29672967
url="https://dashboard.localhost/jobs/testing-farm/6",
2968-
check_name="Packit - custom test(s)",
2968+
check_name="Packit - custom",
29692969
target_branch="rawhide",
29702970
).once()
29712971
flexmock(StatusReporter).should_receive("set_status").with_args(
29722972
state=BaseCommitStatus.running,
29732973
description="Submitting the tests ...",
29742974
url="https://dashboard.localhost/jobs/testing-farm/7",
2975-
check_name="Packit - rpminspect test(s)",
2975+
check_name="Packit - rpminspect",
29762976
target_branch="rawhide",
29772977
).once()
29782978
flexmock(StatusReporter).should_receive("set_status").with_args(
29792979
state=BaseCommitStatus.running,
29802980
description="Tests have been submitted ...",
29812981
url="https://dashboard.localhost/jobs/testing-farm/7",
2982-
check_name="Packit - rpminspect test(s)",
2982+
check_name="Packit - rpminspect",
29832983
target_branch="rawhide",
29842984
).once()
29852985
flexmock(StatusReporter).should_receive("set_status").with_args(
29862986
state=BaseCommitStatus.running,
29872987
description="Submitting the tests ...",
29882988
url="https://dashboard.localhost/jobs/testing-farm/8",
2989-
check_name="Packit - rpmlint test(s)",
2989+
check_name="Packit - rpmlint",
29902990
target_branch="rawhide",
29912991
).once()
29922992
flexmock(StatusReporter).should_receive("set_status").with_args(
29932993
state=BaseCommitStatus.running,
29942994
description="Tests have been submitted ...",
29952995
url="https://dashboard.localhost/jobs/testing-farm/8",
2996-
check_name="Packit - rpmlint test(s)",
2996+
check_name="Packit - rpmlint",
29972997
target_branch="rawhide",
29982998
).once()
29992999

‎tests/integration/test_pr_comment.py‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3455,16 +3455,16 @@ def _test_downstream_tf_retrigger_common(
34553455
"rawhide",
34563456
[
34573457
(
3458-
"6d28c456bdf4e04a37e17a0527b0c633",
3459-
"Packit - installability test(s) - rawhide [beaf90b]",
3458+
"d6180f0168d35be241dd9502ccebf427",
3459+
"Packit - installability - rawhide [beaf90b]",
34603460
),
34613461
(
3462-
"a231e6f97db9f0eeae88562074829b96",
3463-
"Packit - rpminspect test(s) - rawhide [beaf90b]",
3462+
"2c980bef6257ac6f3e40d09151218997",
3463+
"Packit - rpminspect - rawhide [beaf90b]",
34643464
),
34653465
(
3466-
"690a6d39ff6a64745b865d8bf60ae684",
3467-
"Packit - rpmlint test(s) - rawhide [beaf90b]",
3466+
"251118c3a3695047d34973df58f099f1",
3467+
"Packit - rpmlint - rawhide [beaf90b]",
34683468
),
34693469
],
34703470
id="rawhide target branch",
@@ -3473,11 +3473,11 @@ def _test_downstream_tf_retrigger_common(
34733473
"f42",
34743474
[
34753475
(
3476-
"a06b8e95e117b23181a5eb84e6693ed8",
3477-
"Packit - installability test(s) - f42 [beaf90b]",
3476+
"7d0be14827d57f19280b3e08ef7a0aca",
3477+
"Packit - installability - f42 [beaf90b]",
34783478
),
3479-
("2c66f7d41b22fefcbf2647b14ff52781", "Packit - rpminspect test(s) - f42 [beaf90b]"),
3480-
("e0dd5f45df5956423b73de783fd211d0", "Packit - rpmlint test(s) - f42 [beaf90b]"),
3479+
("ef105a8a3c47785c5827647dcfd6ce31", "Packit - rpminspect - f42 [beaf90b]"),
3480+
("2f36dd43d50caa95f0e40c7365f9e4d2", "Packit - rpmlint - f42 [beaf90b]"),
34813481
],
34823482
id="f42 target branch",
34833483
),
@@ -3503,22 +3503,22 @@ def test_downstream_testing_farm_retrigger_via_dist_git_pr_comment(
35033503
pytest.param(
35043504
"/packit-ci test installability",
35053505
"rawhide",
3506-
"6d28c456bdf4e04a37e17a0527b0c633",
3507-
"Packit - installability test(s) - rawhide [beaf90b]",
3506+
"d6180f0168d35be241dd9502ccebf427",
3507+
"Packit - installability - rawhide [beaf90b]",
35083508
id="installability - rawhide target branch",
35093509
),
35103510
pytest.param(
35113511
"/packit-ci test installability",
35123512
"f42",
3513-
"a06b8e95e117b23181a5eb84e6693ed8",
3514-
"Packit - installability test(s) - f42 [beaf90b]",
3513+
"7d0be14827d57f19280b3e08ef7a0aca",
3514+
"Packit - installability - f42 [beaf90b]",
35153515
id="installability - f42 target branch",
35163516
),
35173517
pytest.param(
35183518
"/packit-ci test rpminspect",
35193519
"rawhide",
3520-
"a231e6f97db9f0eeae88562074829b96",
3521-
"Packit - rpminspect test(s) - rawhide [beaf90b]",
3520+
"2c980bef6257ac6f3e40d09151218997",
3521+
"Packit - rpminspect - rawhide [beaf90b]",
35223522
id="rpminspect - rawhide target branch",
35233523
),
35243524
],

‎tests/unit/test_testing_farm.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ def test_downstream_testing_farm_response(
301301
state=status_status,
302302
description=status_message,
303303
url="some url",
304-
check_name="Packit - installability test(s)",
304+
check_name="Packit - installability",
305305
target_branch="rawhide",
306306
).once()
307307

0 commit comments

Comments
 (0)