Skip to content

Commit fb90159

Browse files
committed
Resolve the WSSE middleware from the branch that is being developed
The self-test required it at @dev, which resolves to the default branch. That branch is 212 commits behind v4.x, where the work this harness exercises actually lands, so the suite failed on classes that exist but not there. v4.x is where the engine modernization merged and where the attachment work is headed, so tracking it is what makes this workflow mean something. It goes fully green once the attachment PR lands there; until then the attachment cases fail for want of the classes, and the rest passes.
1 parent 87077f9 commit fb90159

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
name: ci
22

3-
# The harness's own self-test, on PHP 8.4 and 8.5. The committed composer.json declares no
4-
# repositories and requires the middlewares at @dev, so this resolves them from Packagist. It turns
5-
# green once the middleware changes the harness exercises are released to their main branches.
3+
# The harness's own self-test, on PHP 8.4 and 8.5. The committed composer.json declares no repositories, so
4+
# this resolves the middlewares from Packagist: the WSSE one from its active development branch, v4.x, rather
5+
# than from the stale default branch. It turns green once the middleware changes the harness exercises have
6+
# landed there.
67
on:
78
push:
89
pull_request:

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"php": "~8.4.0 || ~8.5.0",
1313
"ext-dom": "*",
1414
"ext-openssl": "*",
15-
"php-soap/psr18-wsse-middleware": "@dev",
15+
"php-soap/psr18-wsse-middleware": "dev-v4.x",
1616
"php-soap/psr18-attachments-middleware": "@dev",
1717
"nyholm/psr7": "^1.8",
1818
"symfony/http-client": "^7.1"

0 commit comments

Comments
 (0)