Faster IsSuperTypeOfResult creation (#5042)

staabm · web-flow · commit 479ff62c59d7 · 2026-02-25T14:32:14.000+01:00
diff --git a/src/Type/Accessory/AccessoryArrayListType.php b/src/Type/Accessory/AccessoryArrayListType.php
@@ -110,8 +110,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isArray()->and($otherType->isList()), []))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isArray()->and($otherType->isList())->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/AccessoryLiteralStringType.php b/src/Type/Accessory/AccessoryLiteralStringType.php
@@ -106,8 +106,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isLiteralString(), []))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isLiteralString()->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/AccessoryLowercaseStringType.php b/src/Type/Accessory/AccessoryLowercaseStringType.php
@@ -103,8 +103,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isLowercaseString(), []))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isLowercaseString()->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/AccessoryNonEmptyStringType.php b/src/Type/Accessory/AccessoryNonEmptyStringType.php
@@ -108,8 +108,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isNonEmptyString(), []))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isNonEmptyString()->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/AccessoryNonFalsyStringType.php b/src/Type/Accessory/AccessoryNonFalsyStringType.php
@@ -110,8 +110,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return IsSuperTypeOfResult::createYes();
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isNonFalsyString(), []))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isNonFalsyString()->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/AccessoryNumericStringType.php b/src/Type/Accessory/AccessoryNumericStringType.php
@@ -103,8 +103,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isNumericString(), []))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isNumericString()->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/AccessoryUppercaseStringType.php b/src/Type/Accessory/AccessoryUppercaseStringType.php
@@ -103,8 +103,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isUppercaseString(), []))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isUppercaseString()->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/HasMethodType.php b/src/Type/Accessory/HasMethodType.php
@@ -100,12 +100,12 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 		}
 
 		if ($otherType instanceof self) {
-			$limit = IsSuperTypeOfResult::createYes();
+			$limit = TrinaryLogic::createYes();
 		} else {
-			$limit = IsSuperTypeOfResult::createMaybe();
+			$limit = TrinaryLogic::createMaybe();
 		}
 
-		return $limit->and(new IsSuperTypeOfResult($otherType->hasMethod($this->methodName), []));
+		return new IsSuperTypeOfResult($limit->and($otherType->hasMethod($this->methodName)), []);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/HasOffsetType.php b/src/Type/Accessory/HasOffsetType.php
@@ -101,10 +101,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		$result = new IsSuperTypeOfResult($otherType->isOffsetAccessible()->and($otherType->hasOffsetValueType($this->offsetType)), []);
-
-		return $result
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isOffsetAccessible()->and($otherType->hasOffsetValueType($this->offsetType))->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/HasOffsetValueType.php b/src/Type/Accessory/HasOffsetValueType.php
@@ -116,11 +116,15 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		$result = new IsSuperTypeOfResult($otherType->isOffsetAccessible()->and($otherType->hasOffsetValueType($this->offsetType)), []);
+		$result = new IsSuperTypeOfResult(
+			$otherType->isOffsetAccessible()
+				->and($otherType->hasOffsetValueType($this->offsetType))
+				->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 
 		return $result
-			->and($otherType->getOffsetValueType($this->offsetType)->isSuperTypeOf($this->valueType))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+			->and($otherType->getOffsetValueType($this->offsetType)->isSuperTypeOf($this->valueType));
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/HasPropertyType.php b/src/Type/Accessory/HasPropertyType.php
@@ -92,15 +92,15 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 		}
 
 		if ($otherType instanceof self) {
-			$limit = IsSuperTypeOfResult::createYes();
+			$limit = TrinaryLogic::createYes();
 		} else {
-			$limit = IsSuperTypeOfResult::createMaybe();
+			$limit = TrinaryLogic::createMaybe();
 		}
 
-		return $limit->and(new IsSuperTypeOfResult(
-			$otherType->hasInstanceProperty($this->propertyName)->or($otherType->hasStaticProperty($this->propertyName)),
+		return new IsSuperTypeOfResult(
+			$limit->and($otherType->hasInstanceProperty($this->propertyName)->or($otherType->hasStaticProperty($this->propertyName))),
 			[],
-		));
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/NonEmptyArrayType.php b/src/Type/Accessory/NonEmptyArrayType.php
@@ -110,8 +110,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isArray()->and($otherType->isIterableAtLeastOnce()), []))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isArray()->and($otherType->isIterableAtLeastOnce())->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/Accessory/OversizedArrayType.php b/src/Type/Accessory/OversizedArrayType.php
@@ -98,8 +98,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isArray()->and($otherType->isOversizedArray()), []))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isArray()->and($otherType->isOversizedArray())->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
diff --git a/src/Type/CallableType.php b/src/Type/CallableType.php
@@ -204,8 +204,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isCallable(), []))
-			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
+		return new IsSuperTypeOfResult(
+			$otherType->isCallable()->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),
+			[],
+		);
 	}
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult

Original file line number	Diff line number	Diff line change
`@@ -110,8 +110,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult`
`110`	`110`	`return $otherType->isSuperTypeOf($this);`
`111`	`111`	`}`
`112`	`112`
`113`		`- return (new IsSuperTypeOfResult($otherType->isArray()->and($otherType->isList()), []))`
`114`		`- ->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());`
	`113`	`+ return new IsSuperTypeOfResult(`
	`114`	`+ $otherType->isArray()->and($otherType->isList())->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),`
	`115`	`+ [],`
	`116`	`+ );`
`115`	`117`	`}`
`116`	`118`
`117`	`119`	`public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult`
Original file line number	Diff line number	Diff line change
`@@ -106,8 +106,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult`
`106`	`106`	`return $otherType->isSuperTypeOf($this);`
`107`	`107`	`}`
`108`	`108`
`109`		`- return (new IsSuperTypeOfResult($otherType->isLiteralString(), []))`
`110`		`- ->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());`
	`109`	`+ return new IsSuperTypeOfResult(`
	`110`	`+ $otherType->isLiteralString()->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),`
	`111`	`+ [],`
	`112`	`+ );`
`111`	`113`	`}`
`112`	`114`
`113`	`115`	`public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult`
Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult`
`103`	`103`	`return $otherType->isSuperTypeOf($this);`
`104`	`104`	`}`
`105`	`105`
`106`		`- return (new IsSuperTypeOfResult($otherType->isLowercaseString(), []))`
`107`		`- ->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());`
	`106`	`+ return new IsSuperTypeOfResult(`
	`107`	`+ $otherType->isLowercaseString()->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),`
	`108`	`+ [],`
	`109`	`+ );`
`108`	`110`	`}`
`109`	`111`
`110`	`112`	`public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult`
Original file line number	Diff line number	Diff line change
`@@ -108,8 +108,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult`
`108`	`108`	`return $otherType->isSuperTypeOf($this);`
`109`	`109`	`}`
`110`	`110`
`111`		`- return (new IsSuperTypeOfResult($otherType->isNonEmptyString(), []))`
`112`		`- ->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());`
	`111`	`+ return new IsSuperTypeOfResult(`
	`112`	`+ $otherType->isNonEmptyString()->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),`
	`113`	`+ [],`
	`114`	`+ );`
`113`	`115`	`}`
`114`	`116`
`115`	`117`	`public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult`
Original file line number	Diff line number	Diff line change
`@@ -100,12 +100,12 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`if ($otherType instanceof self) {`
`103`		`- $limit = IsSuperTypeOfResult::createYes();`
	`103`	`+ $limit = TrinaryLogic::createYes();`
`104`	`104`	`} else {`
`105`		`- $limit = IsSuperTypeOfResult::createMaybe();`
	`105`	`+ $limit = TrinaryLogic::createMaybe();`
`106`	`106`	`}`
`107`	`107`
`108`		`- return $limit->and(new IsSuperTypeOfResult($otherType->hasMethod($this->methodName), []));`
	`108`	`+ return new IsSuperTypeOfResult($limit->and($otherType->hasMethod($this->methodName)), []);`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult`
Original file line number	Diff line number	Diff line change
`@@ -101,10 +101,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult`
`101`	`101`	`return $otherType->isSuperTypeOf($this);`
`102`	`102`	`}`
`103`	`103`
`104`		`- $result = new IsSuperTypeOfResult($otherType->isOffsetAccessible()->and($otherType->hasOffsetValueType($this->offsetType)), []);`
`105`		`-`
`106`		`- return $result`
`107`		`- ->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());`
	`104`	`+ return new IsSuperTypeOfResult(`
	`105`	`+ $otherType->isOffsetAccessible()->and($otherType->hasOffsetValueType($this->offsetType))->and($otherType instanceof self ? TrinaryLogic::createYes() : TrinaryLogic::createMaybe()),`
	`106`	`+ [],`
	`107`	`+ );`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult`