Merge branch refs/heads/2.1.x into 2.2.x

Author: phpstan-bot

tests/PHPStan/Rules/Methods/CallToStaticMethodStatementWithoutSideEffectsRuleTest.php

@@ -121,6 +121,11 @@ public function testBug10819(): void
 		$this->analyse([__DIR__ . '/data/bug-10819.php'], $errors);
 	}
 
+	public function testDynamicStaticCall(): void
+	{
+		$this->analyse([__DIR__ . '/data/dynamic-static-call.php'], []);
+	}
+
 	#[RequiresPhp('>= 8.5')]
 	public function testPipeOperator(): void
 	{

tests/PHPStan/Rules/Methods/data/dynamic-static-call.php

@@ -0,0 +1,36 @@
+<?php
+
+namespace DynamicStaticCall;
+
+class Foo {
+	/** @phpstan-pure */
+	static public function doFoo():int
+	{
+		return 42;
+	}
+}
+
+final class FinalFoo {
+	/** @phpstan-pure */
+	static public function doFoo():int
+	{
+		return 42;
+	}
+}
+
+class Bar {
+	/** @phpstan-pure */
+	final static public function finalFoo():int
+	{
+		return 42;
+	}
+}
+
+
+class Baz {
+	function doBaz(Foo $foo, FinalFoo $finalFoo, Bar $bar):void {
+		$foo::doFoo(); // no error, subclass could override static method with impure impl
+		$finalFoo::doFoo(); // could be "Call to static method .. on a separate line has no effect", because final class
+		$bar::finalFoo(); // could be "Call to static method .. on a separate line has no effect", because final method
+	}
+}