Rework

Author: staabm

…s/Functions/SuperGlobalParameterRule.php …s/Functions/InvalidParameterNameRule.phpsrc/Rules/Functions/SuperGlobalParameterRule.php renamed to src/Rules/Functions/InvalidParameterNameRule.php src/Rules/Functions/SuperGlobalParameterRule.php renamed to src/Rules/Functions/InvalidParameterNameRule.php

@@ -15,7 +15,7 @@
  * @implements Rule<Node\FunctionLike>
  */
 #[RegisteredRule(level: 0)]
-final class SuperGlobalParameterRule implements Rule
+final class InvalidParameterNameRule implements Rule
 {
 
 	public function getNodeType(): string
@@ -36,17 +36,22 @@ public function processNode(Node $node, Scope $scope): array
 				continue;
 			}
 
-			$var = $param->var->name;
-
-			if (!in_array($var, Scope::SUPERGLOBAL_VARIABLES, true)) {
-				continue;
+			$variableName = $param->var->name;
+
+			if (in_array($variableName, Scope::SUPERGLOBAL_VARIABLES, true)) {
+				$errors[] = RuleErrorBuilder::message(sprintf('Cannot re-assign auto-global variable $%s.', $variableName))
+					->line($param->getStartLine())
+					->identifier('parameter.invalidExpr')
+					->nonIgnorable()
+					->build();
+			} elseif ($variableName === 'this') {
+				$errors[] = RuleErrorBuilder::message('Cannot use $this as parameter.')
+					->line($param->getStartLine())
+					->identifier('parameter.invalidExpr')
+					->nonIgnorable()
+					->build();
 			}
 
-			$errors[] = RuleErrorBuilder::message(sprintf('Cannot re-assign auto-global variable $%s.', $var))
-				->line($param->getStartLine())
-				->identifier('parameter.superGlobal')
-				->nonIgnorable()
-				->build();
 		}
 
 		return $errors;

…nctions/SuperGlobalParameterRuleTest.php …nctions/InvalidParameterNameRuleTest.phptests/PHPStan/Rules/Functions/SuperGlobalParameterRuleTest.php renamed to tests/PHPStan/Rules/Functions/InvalidParameterNameRuleTest.php tests/PHPStan/Rules/Functions/SuperGlobalParameterRuleTest.php renamed to tests/PHPStan/Rules/Functions/InvalidParameterNameRuleTest.php

@@ -6,14 +6,14 @@
 use PHPStan\Testing\RuleTestCase;
 
 /**
- * @extends RuleTestCase<SuperGlobalParameterRule>
+ * @extends RuleTestCase<InvalidParameterNameRule>
  */
-class SuperGlobalParameterRuleTest extends RuleTestCase
+class InvalidParameterNameRuleTest extends RuleTestCase
 {
 
 	protected function getRule(): Rule
 	{
-		return new SuperGlobalParameterRule();
+		return new InvalidParameterNameRule();
 	}
 
 	public function testRule(): void
@@ -55,6 +55,10 @@ public function testRule(): void
 				'Cannot re-assign auto-global variable $GLOBALS.',
 				24,
 			],
+			[
+				'Cannot use $this as parameter.',
+				26,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Functions/data/bug-14241.php

@@ -22,3 +22,5 @@ public static function doBar($_SESSION): void {}
 function doQux($_ENV): void {}
 
 function doQuux($GLOBALS): void {}
+
+function doThis($this) {}