Skip to content

Commit e1037e7

Browse files
committed
fixes after rebase
1 parent c87c88c commit e1037e7

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

src/Analyser/Traverser/GenericTypeTemplateTraverser.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace PHPStan\Analyser\Traverser;
44

5-
use PHPStan\Type\ErrorType;
65
use PHPStan\Type\Generic\TemplateType;
76
use PHPStan\Type\Generic\TemplateTypeHelper;
87
use PHPStan\Type\Generic\TemplateTypeMap;
@@ -25,7 +24,7 @@ public function traverse(Type $type, callable $traverse): Type
2524
{
2625
if ($type instanceof TemplateType && !$type->isArgument()) {
2726
$newType = $this->resolvedTemplateTypeMap->getType($type->getName());
28-
if ($newType === null || $newType instanceof ErrorType) {
27+
if ($newType === null || $newType->isError()->yes()) {
2928
return $type->getDefault() ?? $type->getBound();
3029
}
3130

src/Type/ObjectType.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ public function getUnresolvedPropertyPrototype(string $propertyName, ClassMember
226226
}
227227

228228
$property = RecursionGuard::run($this, static fn () => $nakedClassReflection->getProperty($propertyName, $scope));
229-
if ($property instanceof ErrorType) {
229+
if ($property->isError()->yes()) {
230230
$property = new DummyPropertyReflection($propertyName);
231231

232232
return new CallbackUnresolvedPropertyPrototypeReflection(
@@ -332,7 +332,7 @@ public function getUnresolvedInstancePropertyPrototype(string $propertyName, Cla
332332
}
333333

334334
$property = RecursionGuard::run($this, static fn () => $nakedClassReflection->getInstanceProperty($propertyName, $scope));
335-
if ($property instanceof ErrorType) {
335+
if (! $property instanceof ExtendedPropertyReflection) {
336336
$property = new DummyPropertyReflection($propertyName);
337337

338338
return new CallbackUnresolvedPropertyPrototypeReflection(
@@ -414,7 +414,7 @@ public function getUnresolvedStaticPropertyPrototype(string $propertyName, Class
414414
}
415415

416416
$property = RecursionGuard::run($this, static fn () => $nakedClassReflection->getStaticProperty($propertyName));
417-
if ($property instanceof ErrorType) {
417+
if (!$property instanceof ExtendedPropertyReflection) {
418418
$property = new DummyPropertyReflection($propertyName);
419419

420420
return new CallbackUnresolvedPropertyPrototypeReflection(
@@ -1548,7 +1548,7 @@ public function isCallable(): TrinaryLogic
15481548
if ($parametersAcceptors === null) {
15491549
return TrinaryLogic::createNo();
15501550
}
1551-
if ($parametersAcceptors instanceof ErrorType) {
1551+
if (! is_array($parametersAcceptors)) {
15521552
return TrinaryLogic::createNo();
15531553
}
15541554

src/Type/Php/ArrayCombineHelper.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
use PHPStan\Type\ArrayType;
1212
use PHPStan\Type\Constant\ConstantArrayTypeBuilder;
1313
use PHPStan\Type\ConstantScalarType;
14-
use PHPStan\Type\ErrorType;
1514
use PHPStan\Type\MixedType;
1615
use PHPStan\Type\NeverType;
1716
use PHPStan\Type\Type;
@@ -78,7 +77,7 @@ public function getReturnAndThrowType(Expr $firstArg, Expr $secondArg, Scope $sc
7877
$itemType = $keysParamType->getIterableValueType();
7978

8079
if ($itemType->isInteger()->no()) {
81-
if ($itemType->toString() instanceof ErrorType) {
80+
if ($itemType->toString()->isError()->yes()) {
8281
return [new NeverType(), TrinaryLogic::createNo()];
8382
}
8483

@@ -116,7 +115,7 @@ private function sanitizeConstantArrayKeyTypes(array $types): ?array
116115
$sanitizedTypes = [];
117116

118117
foreach ($types as $type) {
119-
if (!$type->isInteger()->yes() && ! $type->toString() instanceof ErrorType) {
118+
if (!$type->isInteger()->yes() && ! $type->toString()->isError()->yes()) {
120119
$type = $type->toString();
121120
}
122121

0 commit comments

Comments
 (0)